mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-18 10:31:15 +00:00
fix(core): Replace throw with warning when deactivating a non-active workflow (#6969)
Replaces a throw with a warning message instead, since the failure in question is not serious enough to warrant stopping the application.
This commit is contained in:
committed by
GitHub
parent
6422078a5d
commit
b6a00febbd
@@ -197,12 +197,13 @@ export class ActiveWorkflows {
|
||||
*
|
||||
* @param {string} id The id of the workflow to deactivate
|
||||
*/
|
||||
async remove(id: string): Promise<void> {
|
||||
async remove(id: string): Promise<boolean> {
|
||||
if (!this.isActive(id)) {
|
||||
// Workflow is currently not registered
|
||||
throw new Error(
|
||||
Logger.warn(
|
||||
`The workflow with the id "${id}" is currently not active and can so not be removed`,
|
||||
);
|
||||
return false;
|
||||
}
|
||||
|
||||
const workflowData = this.workflowData[id];
|
||||
@@ -244,5 +245,7 @@ export class ActiveWorkflows {
|
||||
}
|
||||
|
||||
delete this.workflowData[id];
|
||||
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user