admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 10:31:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): Implement dirty nodes for partial executions (#11739)

Browse Source 
Co-authored-by: Danny Martini <danny@n8n.io>
This commit is contained in:
Raúl Gómez Morales
2024-11-28 14:04:55 +01:00
committed by GitHub
parent 57d3269e40
commit b8da4ff9ed
14 changed files with 270 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
packages/core/src/PartialExecutionUtils/__tests__/findStartNodes.test.ts
View File

@@ -46,7 +46,13 @@ describe('findStartNodes', () => {
const node = createNodeData({ name: 'Basic Node' });
const graph = new DirectedGraph().addNode(node);
const startNodes = findStartNodes({ graph, trigger: node, destination: node });
const startNodes = findStartNodes({
graph,
trigger: node,
destination: node,
pinData: {},
runData: {},
});
expect(startNodes.size).toBe(1);
expect(startNodes).toContainEqual(node);
@@ -65,7 +71,13 @@ describe('findStartNodes', () => {
// if the trigger has no run data
{
const startNodes = findStartNodes({ graph, trigger, destination });
const startNodes = findStartNodes({
graph,
trigger,
destination,
pinData: {},
runData: {},
});
expect(startNodes.size).toBe(1);
expect(startNodes).toContainEqual(trigger);
@@ -77,7 +89,13 @@ describe('findStartNodes', () => {
[trigger.name]: [toITaskData([{ data: { value: 1 } }])],
};
const startNodes = findStartNodes({ graph, trigger, destination, runData });
const startNodes = findStartNodes({
graph,
trigger,
destination,
runData,
pinData: {},
});
expect(startNodes.size).toBe(1);
expect(startNodes).toContainEqual(destination);
@@ -112,7 +130,13 @@ describe('findStartNodes', () => {
};
// ACT
const startNodes = findStartNodes({ graph, trigger, destination: node, runData });
const startNodes = findStartNodes({
graph,
trigger,
destination: node,
runData,
pinData: {},
});
// ASSERT
expect(startNodes.size).toBe(1);
@@ -153,7 +177,13 @@ describe('findStartNodes', () => {
{
// ACT
const startNodes = findStartNodes({ graph, trigger, destination: node4 });
const startNodes = findStartNodes({
graph,
trigger,
destination: node4,
pinData: {},
runData: {},
});
// ASSERT
expect(startNodes.size).toBe(1);
@@ -172,7 +202,13 @@ describe('findStartNodes', () => {
};
// ACT
const startNodes = findStartNodes({ graph, trigger, destination: node4, runData });
const startNodes = findStartNodes({
graph,
trigger,
destination: node4,
runData,
pinData: {},
});
// ASSERT
expect(startNodes.size).toBe(1);
@@ -208,6 +244,7 @@ describe('findStartNodes', () => {
runData: {
[trigger.name]: [toITaskData([{ data: { value: 1 }, outputIndex: 0 }])],
},
pinData: {},
});
// ASSERT
@@ -243,6 +280,7 @@ describe('findStartNodes', () => {
runData: {
[trigger.name]: [toITaskData([{ data: { value: 1 }, outputIndex: 1 }])],
},
pinData: {},
});
// ASSERT
@@ -283,6 +321,7 @@ describe('findStartNodes', () => {
]),
],
},
pinData: {},
});
// ASSERT
@@ -321,6 +360,7 @@ describe('findStartNodes', () => {
[node1.name]: [toITaskData([{ data: { value: 1 }, outputIndex: 0 }])],
[node2.name]: [toITaskData([{ data: { value: 1 }, outputIndex: 0 }])],
},
pinData: {},
});
// ASSERT
@@ -357,6 +397,7 @@ describe('findStartNodes', () => {
[trigger.name]: [toITaskData([{ data: { value: 1 } }])],
[node1.name]: [toITaskData([{ data: { value: 1 }, outputIndex: 1 }])],
},
pinData: {},
});
// ASSERT
@@ -389,7 +430,13 @@ describe('findStartNodes', () => {
const pinData: IPinData = {};
// ACT
const startNodes = findStartNodes({ graph, trigger, destination: node2, runData, pinData });
const startNodes = findStartNodes({
graph,
trigger,
destination: node2,
runData,
pinData,
});
// ASSERT
expect(startNodes.size).toBe(1);

8
packages/core/src/PartialExecutionUtils/findStartNodes.ts
View File

@@ -135,14 +135,14 @@ export function findStartNodes(options: {
graph: DirectedGraph;
trigger: INode;
destination: INode;
runData?: IRunData;
pinData?: IPinData;
pinData: IPinData;
runData: IRunData;
}): Set<INode> {
const graph = options.graph;
const trigger = options.trigger;
const destination = options.destination;
const runData = options.runData ?? {};
const pinData = options.pinData ?? {};
const runData = { ...options.runData };
const pinData = options.pinData;
const startNodes = findStartNodesRecursive(
graph,

7
packages/core/src/WorkflowExecute.ts
View File

@@ -4,6 +4,7 @@
/* eslint-disable @typescript-eslint/prefer-nullish-coalescing */
import * as assert from 'assert/strict';
import { setMaxListeners } from 'events';
import { omit } from 'lodash';
import get from 'lodash/get';
import type {
ExecutionBaseError,
@@ -319,8 +320,9 @@ export class WorkflowExecute {
runPartialWorkflow2(
workflow: Workflow,
runData: IRunData,
pinData: IPinData = {},
dirtyNodeNames: string[] = [],
destinationNodeName?: string,
pinData?: IPinData,
): PCancelable<IRun> {
// TODO: Refactor the call-site to make `destinationNodeName` a required
// after removing the old partial execution flow.
@@ -349,7 +351,8 @@ export class WorkflowExecute {
const filteredNodes = subgraph.getNodes();
// 3. Find the Start Nodes
let startNodes = findStartNodes({ graph: subgraph, trigger, destination, runData });
runData = omit(runData, dirtyNodeNames);
let startNodes = findStartNodes({ graph: subgraph, trigger, destination, runData, pinData });
// 4. Detect Cycles
// 5. Handle Cycles