refactor(editor): Update project settings to use new table component and role selector (#19152)

This commit is contained in:
Csaba Tuncsik
2025-09-16 14:43:10 +02:00
committed by GitHub
parent f0388aae7e
commit b9af51afbd
12 changed files with 2231 additions and 210 deletions

View File

@@ -102,4 +102,237 @@ test.describe('Projects', () => {
await expect(subn8n.page.locator('[data-test-id="resources-list-item"]')).toHaveCount(1);
await expect(subn8n.page.getByRole('heading', { name: 'Notion account' })).toBeVisible();
});
test.describe('Project Settings - Member Management', () => {
test('should display project settings page with correct layout @auth:owner', async ({
n8n,
}) => {
// Create a new project
const { projectId } = await n8n.projectComposer.createProject('UI Test Project');
// Navigate to project settings
await n8n.page.goto(`/projects/${projectId}/settings`);
await n8n.page.waitForLoadState('domcontentloaded');
// Verify basic project settings form elements are visible (inner controls)
await expect(n8n.projectSettings.getNameInput()).toBeVisible();
await expect(n8n.projectSettings.getDescriptionTextarea()).toBeVisible();
await n8n.projectSettings.expectMembersSelectIsVisible();
// Verify members table is visible when there are members
await n8n.projectSettings.expectTableIsVisible();
// Initially should have only the owner (current user)
await n8n.projectSettings.expectTableHasMemberCount(1);
// Verify project settings action buttons are present
await expect(n8n.page.getByTestId('project-settings-save-button')).toBeVisible();
await expect(n8n.page.getByTestId('project-settings-cancel-button')).toBeVisible();
await expect(n8n.page.getByTestId('project-settings-delete-button')).toBeVisible();
});
test('should allow editing project name and description @auth:owner', async ({ n8n }) => {
// Create a new project
const { projectId } = await n8n.projectComposer.createProject('Edit Test Project');
// Navigate to project settings
await n8n.page.goto(`/projects/${projectId}/settings`);
await n8n.page.waitForLoadState('domcontentloaded');
// Update project name
const newName = 'Updated Project Name';
await n8n.projectSettings.fillProjectName(newName);
// Update project description
const newDescription = 'This is an updated project description.';
await n8n.projectSettings.fillProjectDescription(newDescription);
// Save changes
await n8n.projectSettings.clickSaveButton();
// Wait for success notification
await expect(
n8n.page.getByText('Project Updated Project Name saved successfully', { exact: false }),
).toBeVisible();
// Verify the form shows the updated values
await n8n.projectSettings.expectProjectNameValue(newName);
await n8n.projectSettings.expectProjectDescriptionValue(newDescription);
});
test('should display members table with correct structure @auth:owner', async ({ n8n }) => {
// Create a new project
const { projectId } = await n8n.projectComposer.createProject('Table Structure Test');
// Navigate to project settings
await n8n.page.goto(`/projects/${projectId}/settings`);
await n8n.page.waitForLoadState('domcontentloaded');
const table = n8n.projectSettings.getMembersTable();
// Verify table headers are present
await expect(table.getByText('User')).toBeVisible();
await expect(table.getByText('Role')).toBeVisible();
// Verify the owner is displayed in the table
const memberRows = table.locator('tbody tr');
await expect(memberRows).toHaveCount(1);
// Verify owner cannot change their own role
const ownerRow = memberRows.first();
const roleDropdown = ownerRow.getByTestId('project-member-role-dropdown');
await expect(roleDropdown).not.toBeVisible();
});
test('should display role dropdown for members but not for current user @auth:owner', async ({
n8n,
}) => {
// Create a new project
const { projectId } = await n8n.projectComposer.createProject('Role Dropdown Test');
// Navigate to project settings
await n8n.page.goto(`/projects/${projectId}/settings`);
await n8n.page.waitForLoadState('domcontentloaded');
// Current user (owner) should not have a role dropdown
const currentUserRow = n8n.page.locator('tbody tr').first();
await expect(currentUserRow.getByTestId('project-member-role-dropdown')).not.toBeVisible();
// The role should be displayed as static text for the current user
await expect(currentUserRow.getByText('Admin')).toBeVisible();
});
test('should handle member search functionality when search input is used', async ({ n8n }) => {
// Create a new project
const { projectId } = await n8n.projectComposer.createProject('Search Test Project');
// Navigate to project settings
await n8n.page.goto(`/projects/${projectId}/settings`);
await n8n.page.waitForLoadState('domcontentloaded');
// Verify search input is visible
const searchInput = n8n.page.getByTestId('project-members-search');
await expect(searchInput).toBeVisible();
// Test search functionality - enter search term
await searchInput.fill('nonexistent');
// Since we only have the owner, searching for nonexistent should show no filtered results
// But the table structure should still be present
await expect(searchInput).toHaveValue('nonexistent');
// Clear search
await n8n.projectSettings.clearMemberSearch();
await expect(searchInput).toHaveValue('');
});
test('should show project settings form validation @auth:owner', async ({ n8n }) => {
// Create a new project
const { projectId } = await n8n.projectComposer.createProject('Validation Test');
// Navigate to project settings
await n8n.page.goto(`/projects/${projectId}/settings`);
await n8n.page.waitForLoadState('domcontentloaded');
// Clear the project name (required field)
await n8n.projectSettings.fillProjectName('');
// Save button should be disabled when required field is empty
const saveButton = n8n.page.getByTestId('project-settings-save-button');
await expect(saveButton).toBeDisabled();
// Fill in a valid name
await n8n.projectSettings.fillProjectName('Valid Project Name');
// Save button should now be enabled
await expect(saveButton).not.toBeDisabled();
});
test('should handle unsaved changes state @auth:owner', async ({ n8n }) => {
// Create a new project
const { projectId } = await n8n.projectComposer.createProject('Unsaved Changes Test');
// Navigate to project settings
await n8n.page.goto(`/projects/${projectId}/settings`);
await n8n.page.waitForLoadState('domcontentloaded');
// Initially, save and cancel buttons should be disabled (no changes)
await expect(n8n.page.getByTestId('project-settings-save-button')).toBeDisabled();
await expect(n8n.page.getByTestId('project-settings-cancel-button')).toBeDisabled();
// Make a change to the project name
await n8n.projectSettings.fillProjectName('Modified Name');
// Save and cancel buttons should now be enabled
await expect(n8n.page.getByTestId('project-settings-save-button')).not.toBeDisabled();
await expect(n8n.page.getByTestId('project-settings-cancel-button')).not.toBeDisabled();
// Unsaved changes message should be visible
await expect(n8n.page.getByText('You have unsaved changes')).toBeVisible();
// Cancel changes
await n8n.projectSettings.clickCancelButton();
// Buttons should be disabled again
await expect(n8n.page.getByTestId('project-settings-save-button')).toBeDisabled();
await expect(n8n.page.getByTestId('project-settings-cancel-button')).toBeDisabled();
});
test('should display delete project section with warning @auth:owner', async ({ n8n }) => {
// Create a new project
const { projectId } = await n8n.projectComposer.createProject('Delete Test Project');
// Navigate to project settings
await n8n.page.goto(`/projects/${projectId}/settings`);
await n8n.page.waitForLoadState('domcontentloaded');
// Scroll to bottom to see delete section
await n8n.page
.locator('[data-test-id="project-settings-delete-button"]')
.scrollIntoViewIfNeeded();
// Verify danger section is visible with warning
// Copy was updated in UI to use sentence case and expanded description
await expect(n8n.page.getByText('Danger zone')).toBeVisible();
await expect(
n8n.page.getByText(
'When deleting a project, you can also choose to move all workflows and credentials to another project.',
),
).toBeVisible();
await expect(n8n.page.getByTestId('project-settings-delete-button')).toBeVisible();
});
test('should persist settings after page reload @auth:owner', async ({ n8n }) => {
// Create a new project
const { projectId } = await n8n.projectComposer.createProject('Persistence Test');
// Navigate to project settings
await n8n.page.goto(`/projects/${projectId}/settings`);
await n8n.page.waitForLoadState('domcontentloaded');
// Update project details
const projectName = 'Persisted Project Name';
const projectDescription = 'This description should persist after reload';
await n8n.projectSettings.fillProjectName(projectName);
await n8n.projectSettings.fillProjectDescription(projectDescription);
await n8n.projectSettings.clickSaveButton();
// Wait for save confirmation (partial match to include project name)
await expect(
n8n.page.getByText('Project Persisted Project Name saved successfully', { exact: false }),
).toBeVisible();
// Reload the page
await n8n.page.reload();
await n8n.page.waitForLoadState('domcontentloaded');
// Verify data persisted
await n8n.projectSettings.expectProjectNameValue(projectName);
await n8n.projectSettings.expectProjectDescriptionValue(projectDescription);
// Verify table still shows the owner
await n8n.projectSettings.expectTableHasMemberCount(1);
});
});
});