From bb2be8d70580896321641a49a3044165763eb9e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?= =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?= =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?= Date: Mon, 15 Jan 2024 17:52:39 +0100 Subject: [PATCH] fix(Microsoft SQL Node): Fix "Maximum call stack size exceeded" error on too many rows (#8334) --- packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts b/packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts index b1da017730..b5ad6843c4 100644 --- a/packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts +++ b/packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts @@ -248,7 +248,6 @@ export class MicrosoftSql implements INodeType { const pool = configurePool(credentials); await pool.connect(); - const returnItems: INodeExecutionData[] = []; let responseData: IDataObject | IDataObject[] = []; const items = this.getInputData(); @@ -327,12 +326,11 @@ export class MicrosoftSql implements INodeType { const itemData = generatePairedItemData(items.length); - const executionData = this.helpers.constructExecutionMetaData( + const returnItems = this.helpers.constructExecutionMetaData( this.helpers.returnJsonArray(responseData), { itemData }, ); - returnItems.push(...executionData); return [returnItems]; } }