From bc15bb18d9f33abdeed24e26826e7f3308d3eef2 Mon Sep 17 00:00:00 2001 From: Jon Date: Tue, 18 Mar 2025 15:47:30 +0000 Subject: [PATCH] fix: Allow saved credenitals types of up to 64 characters instead of 32 (#13985) --- .../__tests__/create-credential.dto.test.ts | 13 ++++++++++++- .../src/dto/credentials/create-credential.dto.ts | 2 +- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/packages/@n8n/api-types/src/dto/credentials/__tests__/create-credential.dto.test.ts b/packages/@n8n/api-types/src/dto/credentials/__tests__/create-credential.dto.test.ts index d88345cb25..8676d98132 100644 --- a/packages/@n8n/api-types/src/dto/credentials/__tests__/create-credential.dto.test.ts +++ b/packages/@n8n/api-types/src/dto/credentials/__tests__/create-credential.dto.test.ts @@ -34,6 +34,17 @@ describe('CreateCredentialDto', () => { }, }, }, + { + name: 'longer type', + request: { + name: 'LinkedIn Community Management OAuth2 API', + type: 'linkedInCommunityManagementOAuth2Api', + data: { + clientId: '123', + clientSecret: 'secret', + }, + }, + }, ])('should validate $name', ({ request }) => { const result = CreateCredentialDto.safeParse(request); expect(result.success).toBe(true); @@ -110,7 +121,7 @@ describe('CreateCredentialDto', () => { name: 'type too long', request: { name: 'My API Credentials', - type: 'a'.repeat(33), + type: 'a'.repeat(129), data: {}, }, expectedErrorPath: ['type'], diff --git a/packages/@n8n/api-types/src/dto/credentials/create-credential.dto.ts b/packages/@n8n/api-types/src/dto/credentials/create-credential.dto.ts index 368ac2c087..8dd4461813 100644 --- a/packages/@n8n/api-types/src/dto/credentials/create-credential.dto.ts +++ b/packages/@n8n/api-types/src/dto/credentials/create-credential.dto.ts @@ -3,7 +3,7 @@ import { Z } from 'zod-class'; export class CreateCredentialDto extends Z.class({ name: z.string().min(1).max(128), - type: z.string().min(1).max(32), + type: z.string().min(1).max(128), data: z.record(z.string(), z.unknown()), projectId: z.string().optional(), }) {}