admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Load insights module on webhook instance to save insights on webhook workflows (#15433)

Browse Source
This commit is contained in:
Guillaume Jacquart
2025-05-19 10:03:45 +02:00
committed by GitHub
parent d9fdef3bf9
commit bf5551d711
2 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
packages/cli/src/modules/insights/__tests__/insights.pre-init.test.ts
View File

@@ -1,22 +1,25 @@
import { mock } from 'jest-mock-extended';
import type { InstanceSettings } from 'n8n-core';
import type { InstanceSettings, InstanceType } from 'n8n-core';
import type { ModulePreInitContext } from '@/modules/modules.config';
import { shouldLoadModule } from '../insights.pre-init';
describe('InsightsModulePreInit', () => {
it('should return false if instance type is not "main"', () => {
it('should return false if instance type is worker', () => {
const ctx: ModulePreInitContext = {
instance: mock<InstanceSettings>({ instanceType: 'worker' }),
};
expect(shouldLoadModule(ctx)).toBe(false);
});
it('should return true if instance type is "main"', () => {
const ctx: ModulePreInitContext = {
instance: mock<InstanceSettings>({ instanceType: 'main' }),
};
expect(shouldLoadModule(ctx)).toBe(true);
});
it.each<InstanceType>(['main', 'webhook'])(
'should return true if instance type is "%s"',
(instanceType) => {
const ctx: ModulePreInitContext = {
instance: mock<InstanceSettings>({ instanceType }),
};
expect(shouldLoadModule(ctx)).toBe(true);
},
);
});

6
packages/cli/src/modules/insights/insights.pre-init.ts
View File

@@ -1,6 +1,6 @@
import type { ModulePreInitContext } from '../modules.config';
export const shouldLoadModule = (ctx: ModulePreInitContext) =>
// Only main instance(s) should collect insights
// Because main instances are informed of all finished workflow executions, whatever the mode
ctx.instance.instanceType === 'main';
// Only main and webhook instance(s) should collect insights
// Because main and webhooks instances are the ones informed of all finished workflow executions, whatever the mode
ctx.instance.instanceType === 'main' || ctx.instance.instanceType === 'webhook';