admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-19 11:01:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(HTTP Request Node): Resolve max pages expression (#10192)

Browse Source
This commit is contained in:
Elias Meire
2024-07-25 17:35:31 +02:00
committed by GitHub
parent 7775d5059b
commit bfc8e1b56f
2 changed files with 215 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
packages/core/src/NodeExecuteFunctions.ts
View File

@@ -3168,10 +3168,16 @@ const getRequestHelperFunctions = (
additionalKeys.$response = newResponse;
additionalKeys.$pageCount = additionalKeys.$pageCount + 1;
if (
paginationOptions.maxRequests &&
additionalKeys.$pageCount >= paginationOptions.maxRequests
) {
const maxRequests = getResolvedValue(
paginationOptions.maxRequests,
itemIndex,
runIndex,
executeData,
additionalKeys,
false,
) as number;
if (maxRequests && additionalKeys.$pageCount >= maxRequests) {
break;
}
@@ -3186,7 +3192,16 @@ const getRequestHelperFunctions = (
if (makeAdditionalRequest) {
if (paginationOptions.requestInterval) {
await sleep(paginationOptions.requestInterval);
const requestInterval = getResolvedValue(
paginationOptions.requestInterval,
itemIndex,
runIndex,
executeData,
additionalKeys,
false,
) as number;
await sleep(requestInterval);
}
if (tempResponseData.statusCode < 200 || tempResponseData.statusCode >= 300) {
// We have it configured to let all requests pass no matter the response code