From c0c994d24513197b7771951aad67d13dc2749583 Mon Sep 17 00:00:00 2001
From: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
Date: Fri, 18 Jun 2021 22:47:03 +0200
Subject: [PATCH] :zap: Add hooks to Node Lifecycle (#1882)

* :zap: add hook when closing node editing view

* :zap: add hook for node deletion

* :zap: add hook call to escape key
---
 packages/editor-ui/src/components/DataDisplay.vue | 3 +--
 packages/editor-ui/src/components/Node.vue        | 4 +++-
 packages/editor-ui/src/views/NodeView.vue         | 1 +
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/packages/editor-ui/src/components/DataDisplay.vue b/packages/editor-ui/src/components/DataDisplay.vue
index 5102566efb..c32dbcecfe 100644
--- a/packages/editor-ui/src/components/DataDisplay.vue
+++ b/packages/editor-ui/src/components/DataDisplay.vue
@@ -86,11 +86,9 @@ export default mixins(externalHooks, nodeHelpers, workflowHelpers).extend({
 			return this.$store.getters.activeNode;
 		},
 		nodeType (): INodeTypeDescription | null {
-			const activeNode = this.node;
 			if (this.node) {
 				return this.$store.getters.nodeType(this.node.type);
 			}
-
 			return null;
 		},
 	},
@@ -111,6 +109,7 @@ export default mixins(externalHooks, nodeHelpers, workflowHelpers).extend({
 		close (e: MouseEvent) {
 			// @ts-ignore
 			if (e.target.className && e.target.className.includes && e.target.className.includes('close-on-click')) {
+				this.$externalHooks().run('dataDisplay.nodeEditingFinished');
 				this.showDocumentHelp = false;
 				this.$store.commit('setActiveNode', null);
 			}
diff --git a/packages/editor-ui/src/components/Node.vue b/packages/editor-ui/src/components/Node.vue
index 4ce5b36cef..3ba3de90e6 100644
--- a/packages/editor-ui/src/components/Node.vue
+++ b/packages/editor-ui/src/components/Node.vue
@@ -46,6 +46,7 @@
 <script lang="ts">
 
 import Vue from 'vue';
+import { externalHooks } from '@/components/mixins/externalHooks';
 import { nodeBase } from '@/components/mixins/nodeBase';
 import { nodeHelpers } from '@/components/mixins/nodeHelpers';
 import { workflowHelpers } from '@/components/mixins/workflowHelpers';
@@ -59,7 +60,7 @@ import NodeIcon from '@/components/NodeIcon.vue';
 
 import mixins from 'vue-typed-mixins';
 
-export default mixins(nodeBase, nodeHelpers, workflowHelpers).extend({
+export default mixins(externalHooks, nodeBase, nodeHelpers, workflowHelpers).extend({
 	name: 'Node',
 	components: {
 		NodeIcon,
@@ -152,6 +153,7 @@ export default mixins(nodeBase, nodeHelpers, workflowHelpers).extend({
 			this.$emit('runWorkflow', this.data.name, 'Node.executeNode');
 		},
 		deleteNode () {
+			this.$externalHooks().run('node.deleteNode', { node: this.data});
 			Vue.nextTick(() => {
 				// Wait a tick else vue causes problems because the data is gone
 				this.$emit('removeNode', this.data.name);
diff --git a/packages/editor-ui/src/views/NodeView.vue b/packages/editor-ui/src/views/NodeView.vue
index 91268b3a52..7a7dfeff9d 100644
--- a/packages/editor-ui/src/views/NodeView.vue
+++ b/packages/editor-ui/src/views/NodeView.vue
@@ -453,6 +453,7 @@ export default mixins(
 
 					this.callDebounced('deleteSelectedNodes', 500);
 				} else if (e.key === 'Escape') {
+					this.$externalHooks().run('dataDisplay.nodeEditingFinished');
 					this.createNodeActive = false;
 					this.$store.commit('setActiveNode', null);
 				} else if (e.key === 'Tab') {