admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-16 09:36:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(editor): Patch ElementUI tooltip memory leak (#4769)

Browse Source 
* refactor(editor): Fix ElementUI tooltip memory leak

* fix(editor): Remove patch console.logs and revert node-creator test
This commit is contained in:
OlegIvaniv
2022-11-30 17:27:41 +01:00
committed by GitHub
parent cc7f8fd5de
commit c486ffcf2d
6 changed files with 284 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
cypress/e2e/4-node-creator.cy.ts
View File

@@ -97,9 +97,7 @@ describe('Node Creator', () => {
// TODO: Replace once we have canvas feature utils
cy.get('div').contains("On clicking 'execute'").should('exist');
})
// TODO: This tests has to be skipped due to a memory leak in the node creator
// we should unskip it once we have fixed the memory leak
it.skip('check if non-core nodes are rendered', () => {
it('check if non-core nodes are rendered', () => {
cy.wait('@nodesIntercept').then((interception) => {
const nodes = interception.response?.body as INodeTypeDescription[];
@@ -115,9 +113,18 @@ describe('Node Creator', () => {
nodeCreatorFeature.actions.toggleCategory(category)
// Check if all nodes are present
categorizedNodes[category].forEach((node: INodeTypeDescription) => {
if(node.hidden) return;
nodeCreatorFeature.getters.categorizedItems().contains(node.displayName).should('exist');
nodeCreatorFeature.getters.nodeItemName().then($elements => {
const visibleNodes: string[] = [];
$elements.each((_, element) => {
visibleNodes.push(element.textContent?.trim() || '');
})
const visibleCategoryNodes = (categorizedNodes[category] as INodeTypeDescription[])
.filter(node => !node.hidden)
.map(node => node.displayName?.trim());
cy.wrap(visibleCategoryNodes).each((categoryNode: string) => {
expect(visibleNodes).to.include(categoryNode);
});
})
nodeCreatorFeature.actions.toggleCategory(category)

1
cypress/pages/features/node-creator.ts
View File

@@ -16,6 +16,7 @@ export class NodeCreator extends BasePage {
creatorItem: () => cy.getByTestId('item-iterator-item'),
communityNodeTooltip: () => cy.getByTestId('node-item-community-tooltip'),
noResults: () => cy.getByTestId('categorized-no-results'),
nodeItemName: () => cy.getByTestId('node-item-name'),
activeSubcategory: () => cy.getByTestId('categorized-items-subcategory'),
expandedCategories: () => this.getters.creatorItem().find('>div').filter('.active').invoke('text'),
};