admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 10:31:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Integer overflow in insights runtime calculation (#18122)

Browse Source 
Co-authored-by: Shi Nguyễn <prettycode2022@Shis-MacBook-Pro.local>
This commit is contained in:
Shi Nguyễn
2025-08-22 18:05:04 +07:00
committed by GitHub
parent 8b4e8f347f
commit c7678311b3
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/cli/src/modules/insights/insights-collection.service.ts
View File

@@ -42,6 +42,11 @@ const shouldSkipMode: Record<WorkflowExecuteMode, boolean> = {
manual: true, manual: true,
}; };
const MIN_RUNTIME = 0;
// PostgreSQL INTEGER max (signed 32-bit)
const MAX_RUNTIME = 2 ** 31 - 1;
type BufferedInsight = Pick<InsightsRaw, 'type' | 'value' | 'timestamp'> & { type BufferedInsight = Pick<InsightsRaw, 'type' | 'value' | 'timestamp'> & {
workflowId: string; workflowId: string;
workflowName: string; workflowName: string;
@@ -135,7 +140,11 @@ export class InsightsCollectionService {
// run time event // run time event
if (ctx.runData.stoppedAt) { if (ctx.runData.stoppedAt) {
const value = ctx.runData.stoppedAt.getTime() - ctx.runData.startedAt.getTime(); const runtimeMs = ctx.runData.stoppedAt.getTime() - ctx.runData.startedAt.getTime();
if (runtimeMs < MIN_RUNTIME || runtimeMs > MAX_RUNTIME) {
this.logger.warn(`Invalid runtime detected: ${runtimeMs}ms, clamping to safe range`);
}
const value = Math.min(Math.max(runtimeMs, MIN_RUNTIME), MAX_RUNTIME);
this.bufferedInsights.add({ this.bufferedInsights.add({
...commonWorkflowData, ...commonWorkflowData,
type: 'runtime_ms', type: 'runtime_ms',