Use native fs promise where possible (#1684)

This commit is contained in:
lublak
2021-05-01 04:22:15 +02:00
committed by GitHub
parent b7a074abd7
commit c83c05456d
7 changed files with 21 additions and 38 deletions

View File

@@ -1,9 +1,6 @@
import {
readFile as fsReadFile,
} from 'fs';
import { promisify } from 'util';
const fsReadFileAsync = promisify(fsReadFile);
} from 'fs/promises';
import { IExecuteFunctions } from 'n8n-core';
import {
@@ -162,7 +159,7 @@ export class ExecuteWorkflow implements INodeType {
let workflowJson;
try {
workflowJson = await fsReadFileAsync(workflowPath, { encoding: 'utf8' }) as string;
workflowJson = await fsReadFile(workflowPath, { encoding: 'utf8' }) as string;
} catch (error) {
if (error.code === 'ENOENT') {
throw new NodeOperationError(this.getNode(), `The file "${workflowPath}" could not be found.`);

View File

@@ -8,10 +8,7 @@ import {
import {
readFile as fsReadFile,
} from 'fs';
import { promisify } from 'util';
const fsReadFileAsync = promisify(fsReadFile);
} from 'fs/promises';
export class ReadBinaryFile implements INodeType {
@@ -64,7 +61,7 @@ export class ReadBinaryFile implements INodeType {
let data;
try {
data = await fsReadFileAsync(filePath) as Buffer;
data = await fsReadFile(filePath) as Buffer;
} catch (error) {
if (error.code === 'ENOENT') {
throw new NodeOperationError(this.getNode(), `The file "${filePath}" could not be found.`);

View File

@@ -9,10 +9,7 @@ import * as path from 'path';
import {
readFile as fsReadFile,
} from 'fs';
import { promisify } from 'util';
const fsReadFileAsync = promisify(fsReadFile);
} from 'fs/promises';
export class ReadBinaryFiles implements INodeType {
@@ -61,7 +58,7 @@ export class ReadBinaryFiles implements INodeType {
let item: INodeExecutionData;
let data: Buffer;
for (const filePath of files) {
data = await fsReadFileAsync(filePath) as Buffer;
data = await fsReadFile(filePath) as Buffer;
item = {
binary: {

View File

@@ -13,10 +13,7 @@ import {
import {
writeFile as fsWriteFile,
} from 'fs';
import { promisify } from 'util';
const fsWriteFileAsync = promisify(fsWriteFile);
} from 'fs/promises';
export class WriteBinaryFile implements INodeType {
@@ -80,7 +77,7 @@ export class WriteBinaryFile implements INodeType {
}
// Write the file to disk
await fsWriteFileAsync(fileName, Buffer.from(item.binary[dataPropertyName].data, BINARY_ENCODING), 'binary');
await fsWriteFile(fileName, Buffer.from(item.binary[dataPropertyName].data, BINARY_ENCODING), 'binary');
const newItem: INodeExecutionData = {
json: {},