fix(core): Account for waiting jobs during shutdown (#11338)

This commit is contained in:
Iván Ovejero
2024-10-22 17:11:53 +02:00
committed by GitHub
parent 094ec68d4c
commit c863abd083
2 changed files with 47 additions and 11 deletions

View File

@@ -126,13 +126,23 @@ export class ScalingService {
@OnShutdown(HIGHEST_SHUTDOWN_PRIORITY)
async stop() {
await this.queue.pause(true, true); // no more jobs will be picked up
const { instanceType } = this.instanceSettings;
this.logger.debug('Queue paused');
if (instanceType === 'main') await this.stopMain();
else if (instanceType === 'worker') await this.stopWorker();
}
this.stopQueueRecovery();
this.stopQueueMetrics();
private async stopMain() {
if (this.orchestrationService.isSingleMainSetup) {
await this.queue.pause(true, true); // no more jobs will be picked up
this.logger.debug('Queue paused');
}
if (this.queueRecoveryContext.timeout) this.stopQueueRecovery();
if (this.isQueueMetricsEnabled) this.stopQueueMetrics();
}
private async stopWorker() {
let count = 0;
while (this.getRunningJobsCount() !== 0) {