fix(Read Binary File Node): Do not crash the execution when the source file does not exist (#5100)

This issue was introduced in https://github.com/n8n-io/n8n/pull/5069
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™
2023-01-06 14:15:46 +01:00
committed by GitHub
parent c4df2049a8
commit c97f3cad59
5 changed files with 41 additions and 40 deletions

View File

@@ -15,6 +15,7 @@ import type { WorkflowActivationError } from './WorkflowActivationError';
import type { WorkflowOperationError } from './WorkflowErrors';
import type { NodeApiError, NodeOperationError } from './NodeErrors';
import type { ExpressionError } from './ExpressionError';
import { PathLike } from 'fs';
export interface IAdditionalCredentialOptions {
oauth2?: IOAuth2Options;
@@ -640,6 +641,10 @@ export interface JsonHelperFunctions {
returnJsonArray(jsonData: IDataObject | IDataObject[]): INodeExecutionData[];
}
export interface FileSystemHelperFunctions {
createReadStream(path: PathLike): Promise<Readable>;
}
export interface BinaryHelperFunctions {
prepareBinaryData(
binaryData: Buffer | Readable,
@@ -725,6 +730,7 @@ export type IExecuteFunctions = ExecuteFunctions.GetNodeParameterFn &
helpers: RequestHelperFunctions &
BinaryHelperFunctions &
FileSystemHelperFunctions &
JsonHelperFunctions & {
normalizeItems(items: INodeExecutionData | INodeExecutionData[]): INodeExecutionData[];
constructExecutionMetaData(

View File

@@ -217,6 +217,7 @@ abstract class NodeError extends ExecutionBaseError {
}
interface NodeOperationErrorOptions {
message?: string;
description?: string;
runIndex?: number;
itemIndex?: number;
@@ -234,6 +235,9 @@ export class NodeOperationError extends NodeError {
}
super(node, error);
if (options.message) {
this.message = options.message;
}
this.description = options.description;
this.context.runIndex = options.runIndex;
this.context.itemIndex = options.itemIndex;