admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Account for nodes with renamable content (#6109)

Browse Source 
🐛 Account for nodes with renamable content
This commit is contained in:
Iván Ovejero
2023-05-02 09:37:49 +02:00
committed by GitHub
parent 51f5990559
commit c99f158120
3 changed files with 86 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
packages/workflow/test/Workflow.test.ts
View File

@@ -20,7 +20,7 @@ interface StubNode {
}
describe('Workflow', () => {
describe('renameNodeInExpressions', () => {
describe('renameNodeInParameterValue for expressions', () => {
const tests = [
{
description: 'do nothing if there is no expression',
@@ -257,7 +257,7 @@ describe('Workflow', () => {
for (const testData of tests) {
test(testData.description, () => {
const result = workflow.renameNodeInExpressions(
const result = workflow.renameNodeInParameterValue(
testData.input.parameters,
testData.input.currentName,
testData.input.newName,
@@ -267,6 +267,58 @@ describe('Workflow', () => {
}
});
describe('renameNodeInParameterValue for node with renamable content', () => {
const tests = [
{
description: "should work with $('name')",
input: {
currentName: 'Old',
newName: 'New',
parameters: { jsCode: "$('Old').first();" },
},
output: { jsCode: "$('New').first();" },
},
{
description: "should work with $node['name'] and $node.name",
input: {
currentName: 'Old',
newName: 'New',
parameters: { jsCode: "$node['Old'].first(); $node.Old.first();" },
},
output: { jsCode: "$node['New'].first(); $node.New.first();" },
},
{
description: 'should work with $items()',
input: {
currentName: 'Old',
newName: 'New',
parameters: { jsCode: "$items('Old').first();" },
},
output: { jsCode: "$items('New').first();" },
},
];
const workflow = new Workflow({
nodes: [],
connections: {},
active: false,
nodeTypes: Helpers.NodeTypes(),
});
for (const t of tests) {
test(t.description, () => {
expect(
workflow.renameNodeInParameterValue(
t.input.parameters,
t.input.currentName,
t.input.newName,
{ hasRenamableContent: true },
),
).toEqual(t.output);
});
}
});
describe('renameNode', () => {
const tests = [
{
@@ -605,9 +657,9 @@ describe('Workflow', () => {
},
},
},
// This does just a basic test if "renameNodeInExpressions" gets used. More complex
// This does just a basic test if "renameNodeInParameterValue" gets used. More complex
// tests with different formats and levels are in the separate tests for the function
// "renameNodeInExpressions"
// "renameNodeInParameterValue"
{
description: 'change name also in expressions which use node-name (dot notation)',
input: {