admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): updating deepCopy to avoid max callstack with circular deps (#4468)

Browse Source 
* fix(core): updating deepCopy to avoid max callstack in case of circular dep

* fix(core): show warning with path added to circular reference
This commit is contained in:
Csaba Tuncsik
2022-10-28 15:25:44 +02:00
committed by GitHub
parent 7620d93eda
commit ca60b0e203
2 changed files with 46 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/workflow/src/utils.ts
View File

@@ -1,12 +1,16 @@
/* eslint-disable @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-argument */
export const deepCopy = <T>(source: T): T => {
export const deepCopy = <T>(source: T, hash = new WeakMap(), path = ''): T => {
let clone: any;
let i: any;
const hasOwnProp = Object.prototype.hasOwnProperty.bind(source);
// Primitives & Null
if (typeof source !== 'object' || source === null) {
// Primitives & Null & Function
if (typeof source !== 'object' || source === null || source instanceof Function) {
return source;
}
if (hash.has(source)) {
console.warn(`Circular reference detected at "source${path}"`);
return hash.get(source);
}
// Date
if (source instanceof Date) {
return new Date(source.getTime()) as T;
@@ -16,15 +20,16 @@ export const deepCopy = <T>(source: T): T => {
clone = [];
const len = source.length;
for (i = 0; i < len; i++) {
clone[i] = deepCopy(source[i]);
clone[i] = deepCopy(source[i], hash, path + `[${i as string}]`);
}
return clone;
}
// Object
clone = {};
hash.set(source, clone);
for (i in source) {
if (hasOwnProp(i)) {
clone[i] = deepCopy((source as any)[i]);
clone[i] = deepCopy((source as any)[i], hash, path + `.${i as string}`);
}
}
return clone;