admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Jira Trigger Node): Fix Jira webhook subscriptions on Jira v10+ (#14333)

Browse Source
This commit is contained in:
Elias Meire
2025-04-02 12:49:25 +02:00
committed by GitHub
parent 8abbc304f0
commit cd212e4f78
4 changed files with 343 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
packages/nodes-base/nodes/Jira/JiraTrigger.node.ts
View File

@@ -9,7 +9,14 @@ import type {
} from 'n8n-workflow';
import { NodeConnectionTypes, NodeOperationError } from 'n8n-workflow';
import { allEvents, eventExists, getId, jiraSoftwareCloudApiRequest } from './GenericFunctions';
import {
allEvents,
eventExists,
getWebhookId,
getWebhookEndpoint,
jiraSoftwareCloudApiRequest,
} from './GenericFunctions';
import type { JiraWebhook } from './types';
export class JiraTrigger implements INodeType {
description: INodeTypeDescription = {
@@ -411,13 +418,19 @@ export class JiraTrigger implements INodeType {
const events = this.getNodeParameter('events') as string[];
const endpoint = '/webhooks/1.0/webhook';
const endpoint = await getWebhookEndpoint.call(this);
webhookData.endpoint = endpoint;
const webhooks = await jiraSoftwareCloudApiRequest.call(this, endpoint, 'GET', {});
const webhooks: JiraWebhook[] = await jiraSoftwareCloudApiRequest.call(
this,
endpoint,
'GET',
{},
);
for (const webhook of webhooks) {
if (webhook.url === webhookUrl && eventExists(events, webhook.events as string[])) {
webhookData.webhookId = getId(webhook.self as string);
if (webhook.url === webhookUrl && eventExists(events, webhook.events)) {
webhookData.webhookId = getWebhookId(webhook);
return true;
}
}
@@ -429,8 +442,8 @@ export class JiraTrigger implements INodeType {
const webhookUrl = this.getNodeWebhookUrl('default') as string;
let events = this.getNodeParameter('events', []) as string[];
const additionalFields = this.getNodeParameter('additionalFields') as IDataObject;
const endpoint = '/webhooks/1.0/webhook';
const webhookData = this.getWorkflowStaticData('node');
const endpoint = webhookData.endpoint as string;
let authenticateWebhook = false;
@@ -466,7 +479,7 @@ export class JiraTrigger implements INodeType {
body.excludeBody = additionalFields.excludeBody as boolean;
}
const parameters: any = {};
const parameters: Record<string, string> = {};
if (authenticateWebhook) {
let httpQueryAuth;
@@ -494,13 +507,18 @@ export class JiraTrigger implements INodeType {
}
if (Object.keys(parameters as IDataObject).length) {
const params = new URLSearchParams(parameters as string).toString();
const params = new URLSearchParams(parameters).toString();
body.url = `${body.url}?${decodeURIComponent(params)}`;
}
const responseData = await jiraSoftwareCloudApiRequest.call(this, endpoint, 'POST', body);
const responseData: JiraWebhook = await jiraSoftwareCloudApiRequest.call(
this,
endpoint,
'POST',
body,
);
webhookData.webhookId = getId(responseData.self as string);
webhookData.webhookId = getWebhookId(responseData);
return true;
},
@@ -508,7 +526,9 @@ export class JiraTrigger implements INodeType {
const webhookData = this.getWorkflowStaticData('node');
if (webhookData.webhookId !== undefined) {
const endpoint = `/webhooks/1.0/webhook/${webhookData.webhookId}`;
const baseUrl = webhookData.endpoint as string;
const webhookId = webhookData.webhookId as string;
const endpoint = `${baseUrl}/${webhookId}`;
const body = {};
try {