admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Code Node): Do not validate code within comments (#12938)

Browse Source
This commit is contained in:
Ricardo Espinoza
2025-01-30 09:44:35 -05:00
committed by GitHub
parent 9590e5d58b
commit cdfa22593b
2 changed files with 58 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
packages/nodes-base/nodes/Code/test/JsCodeValidator.test.ts Normal file
View File

@@ -0,0 +1,51 @@
import { validateNoDisallowedMethodsInRunForEach } from '../JsCodeValidator';
describe('JsCodeValidator', () => {
describe('validateNoDisallowedMethodsInRunForEach', () => {
it('should not throw error if disallow method is used within single line comments', () => {
const code = [
"// Add a new field called 'myNewField' to the JSON of the item",
'$input.item.json.myNewField = 1;',
' // const xxx = $input.all()',
'return $input.item;',
].join('\n');
expect(() => validateNoDisallowedMethodsInRunForEach(code, 0)).not.toThrow();
});
it('should not throw error if disallow method is used in single multi line comments', () => {
const code = [
"// Add a new field called 'myNewField' to the JSON of the item",
'$input.item.json.myNewField = 1;',
'/** const xxx = $input.all()*/',
'return $input.item;',
].join('\n');
expect(() => validateNoDisallowedMethodsInRunForEach(code, 0)).not.toThrow();
});
it('should not throw error if disallow method is used within multi line comments', () => {
const code = [
"// Add a new field called 'myNewField' to the JSON of the item",
'$input.item.json.myNewField = 1;',
'/**',
'*const xxx = $input.all()',
'*/',
'return $input.item;',
].join('\n');
expect(() => validateNoDisallowedMethodsInRunForEach(code, 0)).not.toThrow();
});
it('should throw error if disallow method is used', () => {
const code = [
"// Add a new field called 'myNewField' to the JSON of the item",
'$input.item.json.myNewField = 1;',
'const xxx = $input.all()',
'return $input.item;',
].join('\n');
expect(() => validateNoDisallowedMethodsInRunForEach(code, 0)).toThrow();
});
});
});