admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

⚡ Improve continueOnFail behaviour

Browse Source
This commit is contained in:
Jan Oberhauser
2020-03-17 13:18:04 +01:00
parent 3bf0a9ab10
commit ce0aaeba7d
4 changed files with 46 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/nodes-base/nodes/HttpRequest.node.ts
View File

@@ -586,9 +586,10 @@ export class HttpRequest implements INodeType {
},
};
let response: any; // tslint:disable-line:no-any
const returnItems: INodeExecutionData[] = [];
for (let itemIndex = 0; itemIndex < items.length; itemIndex++) {
const options = this.getNodeParameter('options', 0, {}) as IDataObject;
const options = this.getNodeParameter('options', itemIndex, {}) as IDataObject;
const url = this.getNodeParameter('url', itemIndex) as string;
const fullResponse = !!options.fullResponse as boolean;
@@ -741,8 +742,17 @@ export class HttpRequest implements INodeType {
requestOptions.json = true;
}
// Now that the options are all set make the actual http request
const response = await this.helpers.request(requestOptions);
try {
// Now that the options are all set make the actual http request
response = await this.helpers.request(requestOptions);
} catch (error) {
if (this.continueOnFail() === true) {
returnItems.push({ json: { error } });
continue;
}
throw error;
}
if (responseFormat === 'file') {
const dataPropertyName = this.getNodeParameter('dataPropertyName', 0) as string;