From d0c8e3f4e7322bae7c9db28e0363603aa2f29bef Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Thu, 9 Apr 2020 00:31:39 +0200 Subject: [PATCH] :zap: Small improvements to Zendesk-Node --- packages/nodes-base/nodes/Zendesk/GenericFunctions.ts | 9 ++++++++- packages/nodes-base/nodes/Zendesk/TicketDescription.ts | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/nodes-base/nodes/Zendesk/GenericFunctions.ts b/packages/nodes-base/nodes/Zendesk/GenericFunctions.ts index b78bfd81f4..f098f97358 100644 --- a/packages/nodes-base/nodes/Zendesk/GenericFunctions.ts +++ b/packages/nodes-base/nodes/Zendesk/GenericFunctions.ts @@ -34,7 +34,14 @@ export async function zendeskApiRequest(this: IHookFunctions | IExecuteFunctions try { return await this.helpers.request!(options); } catch (err) { - const errorMessage = err.response.body.description || err.response.body; + let errorMessage = err.message; + if (err.response && err.response.body && err.response.body.error) { + errorMessage = err.response.body.error; + if (typeof err.response.body.error !== 'string') { + errorMessage = JSON.stringify(errorMessage); + } + } + throw new Error(`Zendesk error response [${err.statusCode}]: ${errorMessage}`); } } diff --git a/packages/nodes-base/nodes/Zendesk/TicketDescription.ts b/packages/nodes-base/nodes/Zendesk/TicketDescription.ts index 177f9d715d..7642248e7e 100644 --- a/packages/nodes-base/nodes/Zendesk/TicketDescription.ts +++ b/packages/nodes-base/nodes/Zendesk/TicketDescription.ts @@ -225,7 +225,7 @@ export const ticketFields = [ }, }, required: true, - description: `Array of customs fields Details`, + description: `Array of customs fields Details`, }, /* -------------------------------------------------------------------------- */ /* ticket:update */