fix(editor): Hide data pinning discoverability tooltip in execution view (#5145)

* fix(editor): remove unused prop

* fix(editor): Prevent data pinning discoverability tooltip displayed in executions view
This commit is contained in:
Csaba Tuncsik
2023-01-13 12:43:51 +01:00
committed by GitHub
parent 665eaef925
commit d10ca530cf
2 changed files with 8 additions and 11 deletions

View File

@@ -590,10 +590,7 @@ export default mixins(externalHooks, genericHelpers, nodeHelpers, pinData).exten
this.eventBus.$on('data-pinning-error', this.onDataPinningError);
this.eventBus.$on('data-unpinning', this.onDataUnpinning);
const hasSeenPinDataTooltip = localStorage.getItem(LOCAL_STORAGE_PIN_DATA_DISCOVERY_NDV_FLAG);
if (!hasSeenPinDataTooltip) {
this.showPinDataDiscoveryTooltip(this.jsonData);
}
this.showPinDataDiscoveryTooltip(this.jsonData);
}
this.ndvStore.setNDVBranchIndex({
pane: this.paneType as 'input' | 'output',
@@ -861,7 +858,12 @@ export default mixins(externalHooks, genericHelpers, nodeHelpers, pinData).exten
return;
}
if (value && value.length > 0) {
if (
value &&
value.length > 0 &&
!this.isReadOnly &&
!localStorage.getItem(LOCAL_STORAGE_PIN_DATA_DISCOVERY_NDV_FLAG)
) {
this.pinDataDiscoveryComplete();
setTimeout(() => {
@@ -1290,11 +1292,7 @@ export default mixins(externalHooks, genericHelpers, nodeHelpers, pinData).exten
},
jsonData(value: IDataObject[]) {
this.refreshDataSize();
const hasSeenPinDataTooltip = localStorage.getItem(LOCAL_STORAGE_PIN_DATA_DISCOVERY_NDV_FLAG);
if (!hasSeenPinDataTooltip) {
this.showPinDataDiscoveryTooltip(value);
}
this.showPinDataDiscoveryTooltip(value);
},
binaryData(newData: IBinaryKeyData[], prevData: IBinaryKeyData[]) {
if (newData.length && !prevData.length && this.displayMode !== 'binary') {