🐛 Fix error when opening ftp/sftp credentials (#2298)

* n8n-2513 fix error when opening credentials

* clean up validation logic
This commit is contained in:
Mutasem Aldmour
2021-10-09 20:42:30 +02:00
committed by GitHub
parent d72d6b4b41
commit d1824b9dd0
2 changed files with 29 additions and 9 deletions

View File

@@ -208,14 +208,16 @@ export default mixins(showMessage, nodeHelpers).extend({
activeNode: this.$store.getters.activeNode,
});
if (this.credentialId) {
if (!this.requiredPropertiesFilled) {
this.showValidationWarning = true;
setTimeout(() => {
if (this.credentialId) {
if (!this.requiredPropertiesFilled) {
this.showValidationWarning = true;
}
else {
this.retestCredential();
}
}
else {
this.retestCredential();
}
}
}, 0);
this.loading = false;
},
@@ -329,7 +331,11 @@ export default mixins(showMessage, nodeHelpers).extend({
continue;
}
if (!this.credentialData[property.name]) {
if (property.type === 'string' && !this.credentialData[property.name]) {
return false;
}
if (property.type === 'number' && typeof this.credentialData[property.name] !== 'number') {
return false;
}
}