diff --git a/packages/@n8n/config/src/configs/runners.config.ts b/packages/@n8n/config/src/configs/runners.config.ts index 500c3337e9..5a6969ba6f 100644 --- a/packages/@n8n/config/src/configs/runners.config.ts +++ b/packages/@n8n/config/src/configs/runners.config.ts @@ -10,9 +10,8 @@ export type TaskRunnerMode = 'internal_childprocess' | 'internal_launcher' | 'ex @Config export class TaskRunnersConfig { - // Defaults to true for now - @Env('N8N_RUNNERS_DISABLED') - disabled: boolean = true; + @Env('N8N_RUNNERS_ENABLED') + enabled: boolean = false; // Defaults to true for now @Env('N8N_RUNNERS_MODE') diff --git a/packages/@n8n/config/test/config.test.ts b/packages/@n8n/config/test/config.test.ts index 71018dee20..eeb98269de 100644 --- a/packages/@n8n/config/test/config.test.ts +++ b/packages/@n8n/config/test/config.test.ts @@ -222,7 +222,7 @@ describe('GlobalConfig', () => { }, }, taskRunners: { - disabled: true, + enabled: false, mode: 'internal_childprocess', path: '/runners', authToken: '', diff --git a/packages/cli/src/commands/start.ts b/packages/cli/src/commands/start.ts index bb8b56d32b..42b5df13e6 100644 --- a/packages/cli/src/commands/start.ts +++ b/packages/cli/src/commands/start.ts @@ -221,7 +221,7 @@ export class Start extends BaseCommand { } const { taskRunners: taskRunnerConfig } = this.globalConfig; - if (!taskRunnerConfig.disabled) { + if (taskRunnerConfig.enabled) { const { TaskRunnerModule } = await import('@/runners/task-runner-module'); const taskRunnerModule = Container.get(TaskRunnerModule); await taskRunnerModule.start(); diff --git a/packages/cli/src/commands/worker.ts b/packages/cli/src/commands/worker.ts index 730c6f6e80..0291a9e416 100644 --- a/packages/cli/src/commands/worker.ts +++ b/packages/cli/src/commands/worker.ts @@ -113,7 +113,7 @@ export class Worker extends BaseCommand { ); const { taskRunners: taskRunnerConfig } = this.globalConfig; - if (!taskRunnerConfig.disabled) { + if (taskRunnerConfig.enabled) { const { TaskRunnerModule } = await import('@/runners/task-runner-module'); const taskRunnerModule = Container.get(TaskRunnerModule); await taskRunnerModule.start(); diff --git a/packages/cli/src/runners/__tests__/task-runner-process.test.ts b/packages/cli/src/runners/__tests__/task-runner-process.test.ts index eb04e3ab8e..fbab9ee1e3 100644 --- a/packages/cli/src/runners/__tests__/task-runner-process.test.ts +++ b/packages/cli/src/runners/__tests__/task-runner-process.test.ts @@ -22,7 +22,7 @@ require('child_process').spawn = spawnMock; describe('TaskRunnerProcess', () => { const logger = mockInstance(Logger); const runnerConfig = mockInstance(TaskRunnersConfig); - runnerConfig.disabled = false; + runnerConfig.enabled = true; runnerConfig.mode = 'internal_childprocess'; const authService = mock(); let taskRunnerProcess = new TaskRunnerProcess(logger, runnerConfig, authService); diff --git a/packages/cli/src/runners/task-runner-module.ts b/packages/cli/src/runners/task-runner-module.ts index f1383f1fba..fe476ad341 100644 --- a/packages/cli/src/runners/task-runner-module.ts +++ b/packages/cli/src/runners/task-runner-module.ts @@ -26,7 +26,7 @@ export class TaskRunnerModule { constructor(private readonly runnerConfig: TaskRunnersConfig) {} async start() { - a.ok(!this.runnerConfig.disabled, 'Task runner is disabled'); + a.ok(this.runnerConfig.enabled, 'Task runner is disabled'); await this.loadTaskManager(); await this.loadTaskRunnerServer(); diff --git a/packages/cli/test/integration/commands/worker.cmd.test.ts b/packages/cli/test/integration/commands/worker.cmd.test.ts index ce3280aa48..e17a8d2279 100644 --- a/packages/cli/test/integration/commands/worker.cmd.test.ts +++ b/packages/cli/test/integration/commands/worker.cmd.test.ts @@ -26,7 +26,7 @@ import { mockInstance } from '../../shared/mocking'; config.set('executions.mode', 'queue'); config.set('binaryDataManager.availableModes', 'filesystem'); -Container.get(TaskRunnersConfig).disabled = false; +Container.get(TaskRunnersConfig).enabled = true; mockInstance(LoadNodesAndCredentials); const binaryDataService = mockInstance(BinaryDataService); const externalHooks = mockInstance(ExternalHooks); diff --git a/packages/cli/test/integration/runners/task-runner-module.external.test.ts b/packages/cli/test/integration/runners/task-runner-module.external.test.ts index e8a7e54f1a..4974abfb39 100644 --- a/packages/cli/test/integration/runners/task-runner-module.external.test.ts +++ b/packages/cli/test/integration/runners/task-runner-module.external.test.ts @@ -18,14 +18,14 @@ describe('TaskRunnerModule in external mode', () => { describe('start', () => { it('should throw if the task runner is disabled', async () => { - runnerConfig.disabled = true; + runnerConfig.enabled = false; // Act await expect(module.start()).rejects.toThrow('Task runner is disabled'); }); it('should start the task runner', async () => { - runnerConfig.disabled = false; + runnerConfig.enabled = true; // Act await module.start(); diff --git a/packages/cli/test/integration/runners/task-runner-module.internal.test.ts b/packages/cli/test/integration/runners/task-runner-module.internal.test.ts index 922f7fee4b..444d576e87 100644 --- a/packages/cli/test/integration/runners/task-runner-module.internal.test.ts +++ b/packages/cli/test/integration/runners/task-runner-module.internal.test.ts @@ -18,14 +18,14 @@ describe('TaskRunnerModule in internal_childprocess mode', () => { describe('start', () => { it('should throw if the task runner is disabled', async () => { - runnerConfig.disabled = true; + runnerConfig.enabled = false; // Act await expect(module.start()).rejects.toThrow('Task runner is disabled'); }); it('should start the task runner', async () => { - runnerConfig.disabled = false; + runnerConfig.enabled = true; // Act await module.start(); diff --git a/packages/cli/test/integration/runners/task-runner-process.test.ts b/packages/cli/test/integration/runners/task-runner-process.test.ts index 219fbc8813..8c5289a5c7 100644 --- a/packages/cli/test/integration/runners/task-runner-process.test.ts +++ b/packages/cli/test/integration/runners/task-runner-process.test.ts @@ -10,7 +10,7 @@ import { retryUntil } from '@test-integration/retry-until'; describe('TaskRunnerProcess', () => { const authToken = 'token'; const runnerConfig = Container.get(TaskRunnersConfig); - runnerConfig.disabled = false; + runnerConfig.enabled = true; runnerConfig.mode = 'internal_childprocess'; runnerConfig.authToken = authToken; runnerConfig.port = 0; // Use any port diff --git a/packages/nodes-base/nodes/Code/Code.node.ts b/packages/nodes-base/nodes/Code/Code.node.ts index e1230b0786..5f9b537d96 100644 --- a/packages/nodes-base/nodes/Code/Code.node.ts +++ b/packages/nodes-base/nodes/Code/Code.node.ts @@ -108,7 +108,7 @@ export class Code implements INodeType { : 'javaScript'; const codeParameterName = language === 'python' ? 'pythonCode' : 'jsCode'; - if (!runnersConfig.disabled && language === 'javaScript') { + if (runnersConfig.enabled && language === 'javaScript') { const code = this.getNodeParameter(codeParameterName, 0) as string; const sandbox = new JsTaskRunnerSandbox(code, nodeMode, workflowMode, this);