admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

🎨 Centralize error throwing for encryption keys and credentials (#3105)

Browse Source 
* Centralized error throwing for encryption key

* Unifying the error message used by cli and core packages

* Improvements to error messages to make it more DRY

* Removed unnecessary throw

* Throwing error when credential does not exist to simplify node behavior (#3112)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
This commit is contained in:
Omar Ajoue
2022-04-15 08:00:47 +02:00
committed by GitHub
parent 17b0cd8f76
commit d3fecb9f6d
227 changed files with 348 additions and 848 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/nodes-base/nodes/Jira/GenericFunctions.ts
View File

@@ -22,17 +22,13 @@ export async function jiraSoftwareCloudApiRequest(this: IHookFunctions | IExecut
const jiraVersion = this.getNodeParameter('jiraVersion', 0) as string;
let jiraCredentials: ICredentialDataDecryptedObject | undefined;
let jiraCredentials: ICredentialDataDecryptedObject;
if (jiraVersion === 'server') {
jiraCredentials = await this.getCredentials('jiraSoftwareServerApi');
} else {
jiraCredentials = await this.getCredentials('jiraSoftwareCloudApi');
}
if (jiraCredentials === undefined) {
throw new NodeOperationError(this.getNode(), 'No credentials got returned!');
}
if (jiraVersion === 'server') {
domain = jiraCredentials!.domain;
data = Buffer.from(`${jiraCredentials!.email}:${jiraCredentials!.password}`).toString('base64');
@@ -120,7 +116,7 @@ export function getId(url: string) {
return url.split('/').pop();
}
export function simplifyIssueOutput(responseData: {
export function simplifyIssueOutput(responseData: {
names: { [key: string]: string },
fields: IDataObject,
id: string,