🎨 Centralize error throwing for encryption keys and credentials (#3105)

* Centralized error throwing for encryption key

* Unifying the error message used by cli and core packages

* Improvements to error messages to make it more DRY

* Removed unnecessary throw

* Throwing error when credential does not exist to simplify node behavior (#3112)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
This commit is contained in:
Omar Ajoue
2022-04-15 08:00:47 +02:00
committed by GitHub
parent 17b0cd8f76
commit d3fecb9f6d
227 changed files with 348 additions and 848 deletions

View File

@@ -483,10 +483,7 @@ export interface IExecuteFunctions {
inputData?: INodeExecutionData[],
): Promise<any>;
getContext(type: string): IContextObject;
getCredentials(
type: string,
itemIndex?: number,
): Promise<ICredentialDataDecryptedObject | undefined>;
getCredentials(type: string, itemIndex?: number): Promise<ICredentialDataDecryptedObject>;
getInputData(inputIndex?: number, inputName?: string): INodeExecutionData[];
getMode(): WorkflowExecuteMode;
getNode(): INode;
@@ -533,7 +530,7 @@ export interface IExecuteSingleFunctions {
itemIndex: number | undefined,
): NodeParameterValue | INodeParameters | NodeParameterValue[] | INodeParameters[];
getContext(type: string): IContextObject;
getCredentials(type: string): Promise<ICredentialDataDecryptedObject | undefined>;
getCredentials(type: string): Promise<ICredentialDataDecryptedObject>;
getInputData(inputIndex?: number, inputName?: string): INodeExecutionData;
getMode(): WorkflowExecuteMode;
getNode(): INode;
@@ -583,7 +580,7 @@ export interface ICredentialTestFunctions {
}
export interface ILoadOptionsFunctions {
getCredentials(type: string): Promise<ICredentialDataDecryptedObject | undefined>;
getCredentials(type: string): Promise<ICredentialDataDecryptedObject>;
getNode(): INode;
getNodeParameter(
parameterName: string,
@@ -624,7 +621,7 @@ export interface ILoadOptionsFunctions {
}
export interface IHookFunctions {
getCredentials(type: string): Promise<ICredentialDataDecryptedObject | undefined>;
getCredentials(type: string): Promise<ICredentialDataDecryptedObject>;
getMode(): WorkflowExecuteMode;
getActivationMode(): WorkflowActivateMode;
getNode(): INode;
@@ -654,7 +651,7 @@ export interface IHookFunctions {
export interface IPollFunctions {
__emit(data: INodeExecutionData[][]): void;
getCredentials(type: string): Promise<ICredentialDataDecryptedObject | undefined>;
getCredentials(type: string): Promise<ICredentialDataDecryptedObject>;
getMode(): WorkflowExecuteMode;
getActivationMode(): WorkflowActivateMode;
getNode(): INode;
@@ -686,7 +683,7 @@ export interface ITriggerFunctions {
responsePromise?: IDeferredPromise<IExecuteResponsePromiseData>,
): void;
emitError(error: Error, responsePromise?: IDeferredPromise<IExecuteResponsePromiseData>): void;
getCredentials(type: string): Promise<ICredentialDataDecryptedObject | undefined>;
getCredentials(type: string): Promise<ICredentialDataDecryptedObject>;
getMode(): WorkflowExecuteMode;
getActivationMode(): WorkflowActivateMode;
getNode(): INode;
@@ -714,7 +711,7 @@ export interface ITriggerFunctions {
export interface IWebhookFunctions {
getBodyData(): IDataObject;
getCredentials(type: string): Promise<ICredentialDataDecryptedObject | undefined>;
getCredentials(type: string): Promise<ICredentialDataDecryptedObject>;
getHeaderData(): object;
getMode(): WorkflowExecuteMode;
getNode(): INode;