admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): Remove unknown credentials on pasting workflow (#7582)

Browse Source 
https://linear.app/n8n/issue/PAY-881
This commit is contained in:
Iván Ovejero
2023-11-02 17:26:39 +01:00
committed by GitHub
parent 81f43805aa
commit d633753687
3 changed files with 90 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
cypress/e2e/12-canvas.cy.ts
View File

@@ -34,10 +34,10 @@ describe('Canvas Node Manipulation and Navigation', () => {
WorkflowPage.actions.addNodeToCanvas(SWITCH_NODE_NAME, true, true);
for (let i = 0; i < desiredOutputs; i++) {
cy.contains('Add Routing Rule').click()
cy.contains('Add Routing Rule').click();
}
NDVDialog.actions.close()
NDVDialog.actions.close();
for (let i = 0; i < desiredOutputs; i++) {
WorkflowPage.getters.canvasNodePlusEndpointByName(SWITCH_NODE_NAME, i).click({ force: true });
WorkflowPage.getters.nodeCreatorSearchBar().should('be.visible');
@@ -51,7 +51,9 @@ describe('Canvas Node Manipulation and Navigation', () => {
cy.reload();
cy.waitForLoad();
// Make sure outputless switch was connected correctly
cy.get(`[data-target-node="${SWITCH_NODE_NAME}1"][data-source-node="${EDIT_FIELDS_SET_NODE_NAME}3"]`).should('be.visible');
cy.get(
`[data-target-node="${SWITCH_NODE_NAME}1"][data-source-node="${EDIT_FIELDS_SET_NODE_NAME}3"]`,
).should('be.visible');
// Make sure all connections are there after reload
for (let i = 0; i < desiredOutputs; i++) {
const setName = `${EDIT_FIELDS_SET_NODE_NAME}${i > 0 ? i : ''}`;
@@ -179,7 +181,7 @@ describe('Canvas Node Manipulation and Navigation', () => {
.canvasNodes()
.last()
.should('have.css', 'left', '740px')
.should('have.css', 'top', '320px')
.should('have.css', 'top', '320px');
});
it('should zoom in', () => {
@@ -350,5 +352,17 @@ describe('Canvas Node Manipulation and Navigation', () => {
cy.waitForLoad();
WorkflowPage.getters.canvasNodes().should('have.length', 2);
cy.get('.rect-input-endpoint.jtk-endpoint-connected').should('have.length', 1);
})
});
it('should remove unknown credentials on pasting workflow', () => {
cy.fixture('workflow-with-unknown-credentials.json').then((data) => {
cy.get('body').paste(JSON.stringify(data));
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
WorkflowPage.actions.openNode('n8n');
cy.get('[class*=hasIssues]').should('have.length', 1);
NDVDialog.actions.close();
});
});
});