refactor(core): Remove roleId indirection (no-changelog) (#8413)

packages/cli/src/controllers/owner.controller.ts

@@ -15,7 +15,7 @@ import { BadRequestError } from '@/errors/response-errors/bad-request.error';
 import { InternalHooks } from '@/InternalHooks';
 import { UserRepository } from '@/databases/repositories/user.repository';
 
-@Authorized(['global', 'owner'])
+@Authorized('global:owner')
 @RestController('/owner')
 export class OwnerController {
 	constructor(
@@ -35,7 +35,7 @@ export class OwnerController {
 	@Post('/setup')
 	async setupOwner(req: OwnerRequest.Post, res: Response) {
 		const { email, firstName, lastName, password } = req.body;
-		const { id: userId, globalRole } = req.user;
+		const { id: userId } = req.user;
 
 		if (config.getEnv('userManagement.isInstanceOwnerSetUp')) {
 			this.logger.debug(
@@ -65,17 +65,6 @@ export class OwnerController {
 			throw new BadRequestError('First and last names are mandatory');
 		}
 
-		// TODO: This check should be in a middleware outside this class
-		if (globalRole.scope === 'global' && globalRole.name !== 'owner') {
-			this.logger.debug(
-				'Request to claim instance ownership failed because user shell does not exist or has wrong role!',
-				{
-					userId,
-				},
-			);
-			throw new BadRequestError('Invalid request');
-		}
-
 		let owner = req.user;
 
 		Object.assign(owner, {