admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Moved MongoDb connection string override into credentials (#1)

Browse Source 
* interim work on credentials refactor

* move conn string override for mongodb into credentials and enhance credentials typings
This commit is contained in:
Chris Lonardo
2020-04-06 21:07:54 -04:00
committed by GitHub
parent 00fc6e5980
commit d80deda34f
5 changed files with 149 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
packages/nodes-base/nodes/MongoDb/MongoDb.node.ts
View File

@@ -7,47 +7,25 @@ import {
} from 'n8n-workflow';
import { nodeDescription } from './mongo.node.options';
import { MongoClient } from 'mongodb';
import { getItemCopy, buildParameterizedConnString } from './mongo.node.utils';
import {
getItemCopy,
validateAndResolveMongoCredentials
} from './mongo.node.utils';
export class MongoDb implements INodeType {
description: INodeTypeDescription = nodeDescription;
async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
const credentials = this.getCredentials('mongoDb');
const { database, connectionString } = validateAndResolveMongoCredentials(
this.getCredentials('mongoDb')
);
// user can optionally override connection string
const useOverriddenConnString = this.getNodeParameter(
'shouldOverrideConnString',
0
) as boolean;
if (credentials === undefined) {
throw new Error('No credentials got returned!');
}
let connectionUri = '';
if (useOverriddenConnString === true) {
const connStringInput = this.getNodeParameter(
'connStringOverrideVal',
0
) as string;
if (connStringInput && connStringInput.length > 0) {
connectionUri = connStringInput;
} else {
throw new Error(
'Cannot override credentials: valid MongoDB connection string not provided '
);
}
} else {
connectionUri = buildParameterizedConnString(credentials);
}
const client: MongoClient = await MongoClient.connect(connectionUri, {
const client: MongoClient = await MongoClient.connect(connectionString, {
useNewUrlParser: true,
useUnifiedTopology: true
});
const mdb = client.db(credentials.database as string);
const mdb = client.db(database as string);
let returnItems = [];