mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-17 10:02:05 +00:00
refactor(core): Reorganize error hierarchy in core and workflow packages (no-changelog) (#7820)
Ensure all errors in `core` and `workflow` inherit from `ApplicationError` so that we start normalizing all the errors we report to Sentry Follow-up to: https://github.com/n8n-io/n8n/pull/7757#discussion_r1404338844 ### `core` package `ApplicationError` - `FileSystemError` (abstract) - `FileNotFoundError` - `DisallowedFilepathError` - `BinaryDataError` (abstract) - `InvalidModeError` - `InvalidManagerError` - `InvalidExecutionMetadataError` ### `workflow` package `ApplicationError` - `ExecutionBaseError` (abstract) - `WorkflowActivationError` - `WorkflowDeactivationError` - `WebhookTakenError` - `WorkflowOperationError` - `SubworkflowOperationError` - `CliWorkflowOperationError` - `ExpressionError` - `ExpressionExtensionError` - `NodeError` (abstract) - `NodeOperationError` - `NodeApiError` - `NodeSSLError` Up next: - Reorganize errors in `cli` - Flatten the hierarchy in `workflow` (do we really need `ExecutionBaseError`?) - Remove `ExecutionError` type - Stop throwing plain `Error`s - Replace `severity` with `level` - Add node and credential types as `tags` - Add workflow IDs and execution IDs as `extras`
This commit is contained in:
@@ -1,10 +1,10 @@
|
||||
// import { createHash } from 'crypto';
|
||||
import { titleCase } from 'title-case';
|
||||
import * as ExpressionError from '../ExpressionError';
|
||||
import type { ExtensionMap } from './Extensions';
|
||||
import CryptoJS from 'crypto-js';
|
||||
import { encode } from 'js-base64';
|
||||
import { transliterate } from 'transliteration';
|
||||
import { ExpressionExtensionError } from '../errors/expression-extension.error';
|
||||
|
||||
const hashFunctions: Record<string, typeof CryptoJS.MD5> = {
|
||||
md5: CryptoJS.MD5,
|
||||
@@ -122,7 +122,7 @@ function hash(value: string, extraArgs?: unknown): string {
|
||||
}
|
||||
const hashFunction = hashFunctions[algorithm.toLowerCase()];
|
||||
if (!hashFunction) {
|
||||
throw new ExpressionError.ExpressionExtensionError(
|
||||
throw new ExpressionExtensionError(
|
||||
`Unknown algorithm ${algorithm}. Available algorithms are: ${Object.keys(hashFunctions)
|
||||
.map((s) => s.toUpperCase())
|
||||
.join(', ')}, and Base64.`,
|
||||
@@ -194,7 +194,7 @@ function toDate(value: string): Date {
|
||||
const date = new Date(Date.parse(value));
|
||||
|
||||
if (date.toString() === 'Invalid Date') {
|
||||
throw new ExpressionError.ExpressionExtensionError('cannot convert to date');
|
||||
throw new ExpressionExtensionError('cannot convert to date');
|
||||
}
|
||||
// If time component is not specified, force 00:00h
|
||||
if (!/:/.test(value)) {
|
||||
@@ -224,7 +224,7 @@ function toInt(value: string, extraArgs: Array<number | undefined>) {
|
||||
const int = parseInt(value.replace(CURRENCY_REGEXP, ''), radix);
|
||||
|
||||
if (isNaN(int)) {
|
||||
throw new ExpressionError.ExpressionExtensionError('cannot convert to integer');
|
||||
throw new ExpressionExtensionError('cannot convert to integer');
|
||||
}
|
||||
|
||||
return int;
|
||||
@@ -232,15 +232,13 @@ function toInt(value: string, extraArgs: Array<number | undefined>) {
|
||||
|
||||
function toFloat(value: string) {
|
||||
if (value.includes(',')) {
|
||||
throw new ExpressionError.ExpressionExtensionError(
|
||||
'cannot convert to float, expected . as decimal separator',
|
||||
);
|
||||
throw new ExpressionExtensionError('cannot convert to float, expected . as decimal separator');
|
||||
}
|
||||
|
||||
const float = parseFloat(value.replace(CURRENCY_REGEXP, ''));
|
||||
|
||||
if (isNaN(float)) {
|
||||
throw new ExpressionError.ExpressionExtensionError('cannot convert to float');
|
||||
throw new ExpressionExtensionError('cannot convert to float');
|
||||
}
|
||||
|
||||
return float;
|
||||
|
||||
Reference in New Issue
Block a user