fix(Jira Software Node): Use old endpoints to get all issues on self-hosted instances (#15591)

packages/nodes-base/nodes/Jira/Jira.node.ts

@@ -822,24 +822,43 @@ export class Jira implements INodeType {
 						}
 					}
 					if (returnAll) {
-						responseData = await jiraSoftwareCloudApiRequestAllItems.call(
+						if (jiraVersion === 'server' || jiraVersion === 'serverPat') {
-							this,
+							responseData = await jiraSoftwareCloudApiRequestAllItems.call(
-							'issues',
+								this,
-							'/api/2/search/jql',
+								'issues',
-							'POST',
+								'/api/2/search',
-							body,
+								'POST',
-							{},
+								body,
-							'token',
+							);
-						);
+						} else {
+							responseData = await jiraSoftwareCloudApiRequestAllItems.call(
+								this,
+								'issues',
+								'/api/2/search/jql',
+								'POST',
+								body,
+								{},
+								'token',
+							);
+						}
 					} else {
 						const limit = this.getNodeParameter('limit', i);
 						body.maxResults = limit;
-						responseData = await jiraSoftwareCloudApiRequest.call(
+						if (jiraVersion === 'server' || jiraVersion === 'serverPat') {
-							this,
+							responseData = await jiraSoftwareCloudApiRequest.call(
-							'/api/2/search/jql',
+								this,
-							'POST',
+								'/api/2/search',
-							body,
+								'POST',
-						);
+								body,
+							);
+						} else {
+							responseData = await jiraSoftwareCloudApiRequest.call(
+								this,
+								'/api/2/search/jql',
+								'POST',
+								body,
+							);
+						}
 						responseData = responseData.issues;
 					}
 

packages/nodes-base/nodes/Jira/__test__/Jira.node.test.ts

@@ -2,14 +2,17 @@ import type { DeepMockProxy } from 'jest-mock-extended';
 import { mockDeep } from 'jest-mock-extended';
 import type { IExecuteFunctions } from 'n8n-workflow';
 
-import * as GenericFunctions from '../../GenericFunctions';
+import * as GenericFunctions from '../GenericFunctions';
-import { Jira } from '../../Jira.node';
+import { Jira } from '../Jira.node';
 
-jest.mock('../../GenericFunctions', () => ({
+jest.mock('../GenericFunctions', () => ({
 	jiraSoftwareCloudApiRequest: jest.fn().mockResolvedValue({ issues: [] }),
+	jiraSoftwareCloudApiRequestAllItems: jest.fn().mockResolvedValue([]),
 }));
 
 const jiraSoftwareCloudApiRequestMock = GenericFunctions.jiraSoftwareCloudApiRequest as jest.Mock;
+const jiraSoftwareCloudApiRequestAllItems =
+	GenericFunctions.jiraSoftwareCloudApiRequestAllItems as jest.Mock;
 
 describe('Jira Node', () => {
 	let jiraNode: Jira;
@@ -148,5 +151,98 @@ describe('Jira Node', () => {
 				}),
 			);
 		});
+
+		it('should call new endpoint for the cloud version with return all = true', async () => {
+			executeFunctionsMock.getNodeParameter.mockImplementation((parameterName: string) => {
+				switch (parameterName) {
+					case 'resource':
+						return 'issue';
+					case 'operation':
+						return 'getAll';
+					case 'jiraVersion':
+						return 'cloud';
+					case 'returnAll':
+						return true;
+					case 'options':
+						return {};
+					default:
+						return null;
+				}
+			});
+
+			await jiraNode.execute.call(executeFunctionsMock);
+
+			expect(jiraSoftwareCloudApiRequestAllItems).toHaveBeenCalledWith(
+				'issues',
+				'/api/2/search/jql',
+				'POST',
+				expect.anything(),
+				{},
+				'token',
+			);
+		});
+
+		it.each([['server'], ['serverPat']])(
+			'should call old endpoint for the self-hosted version with return all = false',
+			async (jiraVersion: string) => {
+				executeFunctionsMock.getNodeParameter.mockImplementation((parameterName: string) => {
+					switch (parameterName) {
+						case 'resource':
+							return 'issue';
+						case 'operation':
+							return 'getAll';
+						case 'jiraVersion':
+							return jiraVersion;
+						case 'returnAll':
+							return false;
+						case 'limit':
+							return 10;
+						case 'options':
+							return {};
+						default:
+							return null;
+					}
+				});
+
+				await jiraNode.execute.call(executeFunctionsMock);
+
+				expect(jiraSoftwareCloudApiRequestMock).toHaveBeenCalledWith(
+					'/api/2/search',
+					'POST',
+					expect.anything(),
+				);
+			},
+		);
+
+		it.each([['server'], ['serverPat']])(
+			'should call old endpoint for the self-hosted version with return all = true',
+			async (jiraVersion: string) => {
+				executeFunctionsMock.getNodeParameter.mockImplementation((parameterName: string) => {
+					switch (parameterName) {
+						case 'resource':
+							return 'issue';
+						case 'operation':
+							return 'getAll';
+						case 'jiraVersion':
+							return jiraVersion;
+						case 'returnAll':
+							return true;
+						case 'options':
+							return {};
+						default:
+							return null;
+					}
+				});
+
+				await jiraNode.execute.call(executeFunctionsMock);
+
+				expect(jiraSoftwareCloudApiRequestAllItems).toHaveBeenCalledWith(
+					'issues',
+					'/api/2/search',
+					'POST',
+					expect.anything(),
+				);
+			},
+		);
 	});
 });