refactor: Switch plain errors in nodes-base to ApplicationError (no-changelog) (#7914)

Ensure all errors in `nodes-base` are `ApplicationError` or children of
it and contain no variables in the message, to continue normalizing all
the backend errors we report to Sentry. Also, skip reporting to Sentry
errors from user input and from external APIs. In future we should
refine `ApplicationError` to more specific errors.

Follow-up to: [#7877](https://github.com/n8n-io/n8n/pull/7877)

- [x] Test workflows:
https://github.com/n8n-io/n8n/actions/runs/7084627970
- [x] e2e: https://github.com/n8n-io/n8n/actions/runs/7084936861

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
Iván Ovejero
2023-12-05 11:17:08 +01:00
committed by GitHub
parent 38b88b946b
commit e77fd5d286
33 changed files with 164 additions and 86 deletions

View File

@@ -1,3 +1,4 @@
import { ApplicationError } from 'n8n-workflow';
import type {
ICredentialDataDecryptedObject,
ICredentialType,
@@ -76,7 +77,7 @@ export class CustomerIoApi implements ICredentialType {
Authorization: `Bearer ${credentials.appApiKey as string}`,
});
} else {
throw new Error('Unknown way of authenticating');
throw new ApplicationError('Unknown way of authenticating', { level: 'warning' });
}
return requestOptions;

View File

@@ -1,3 +1,4 @@
import { ApplicationError } from 'n8n-workflow';
import type {
IAuthenticateGeneric,
ICredentialDataDecryptedObject,
@@ -120,7 +121,9 @@ export class ZscalerZiaApi implements ICredentialType {
?.find((entry) => entry.includes('JSESSIONID'));
if (!cookie) {
throw new Error('No cookie returned. Please check your credentials.');
throw new ApplicationError('No cookie returned. Please check your credentials.', {
level: 'warning',
});
}
return { cookie };