mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-17 18:12:04 +00:00
refactor: Switch plain errors in nodes-base to ApplicationError (no-changelog) (#7914)
Ensure all errors in `nodes-base` are `ApplicationError` or children of it and contain no variables in the message, to continue normalizing all the backend errors we report to Sentry. Also, skip reporting to Sentry errors from user input and from external APIs. In future we should refine `ApplicationError` to more specific errors. Follow-up to: [#7877](https://github.com/n8n-io/n8n/pull/7877) - [x] Test workflows: https://github.com/n8n-io/n8n/actions/runs/7084627970 - [x] e2e: https://github.com/n8n-io/n8n/actions/runs/7084936861 --------- Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
@@ -5,7 +5,7 @@ import type {
|
||||
ILoadOptionsFunctions,
|
||||
JsonObject,
|
||||
} from 'n8n-workflow';
|
||||
import { jsonParse, NodeApiError } from 'n8n-workflow';
|
||||
import { ApplicationError, jsonParse, NodeApiError } from 'n8n-workflow';
|
||||
|
||||
export const messageFields = [
|
||||
'bccRecipients',
|
||||
@@ -157,7 +157,9 @@ export function createMessage(fields: IDataObject) {
|
||||
} else if (typeof value === 'string') {
|
||||
message[key] = value.split(',').map((recipient: string) => makeRecipient(recipient.trim()));
|
||||
} else {
|
||||
throw new Error(`The "${key}" field must be a string or an array of strings`);
|
||||
throw new ApplicationError(`The "${key}" field must be a string or an array of strings`, {
|
||||
level: 'warning',
|
||||
});
|
||||
}
|
||||
continue;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user