admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Switch plain errors in nodes-base to ApplicationError (no-changelog) (#7914)

Browse Source 
Ensure all errors in `nodes-base` are `ApplicationError` or children of
it and contain no variables in the message, to continue normalizing all
the backend errors we report to Sentry. Also, skip reporting to Sentry
errors from user input and from external APIs. In future we should
refine `ApplicationError` to more specific errors.

Follow-up to: [#7877](https://github.com/n8n-io/n8n/pull/7877)

- [x] Test workflows:
https://github.com/n8n-io/n8n/actions/runs/7084627970
- [x] e2e: https://github.com/n8n-io/n8n/actions/runs/7084936861

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
Iván Ovejero
2023-12-05 11:17:08 +01:00
committed by GitHub
parent 38b88b946b
commit e77fd5d286
33 changed files with 164 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/nodes-base/test/nodes/Helpers.ts
View File

@@ -32,7 +32,7 @@ import type {
NodeLoadingDetails,
WorkflowTestData,
} from 'n8n-workflow';
import { ICredentialsHelper, NodeHelpers, WorkflowHooks } from 'n8n-workflow';
import { ApplicationError, ICredentialsHelper, NodeHelpers, WorkflowHooks } from 'n8n-workflow';
import { executeWorkflow } from './ExecuteWorkflow';
import { FAKE_CREDENTIALS_DATA } from './FakeCredentialsMap';
@@ -240,7 +240,9 @@ export function setup(testData: WorkflowTestData[] | WorkflowTestData) {
for (const credentialName of credentialNames) {
const loadInfo = knownCredentials[credentialName];
if (!loadInfo) {
throw new Error(`Unknown credential type: ${credentialName}`);
throw new ApplicationError(`Unknown credential type: ${credentialName}`, {
level: 'warning',
});
}
const sourcePath = loadInfo.sourcePath.replace(/^dist\//, './').replace(/\.js$/, '.ts');
const nodeSourcePath = path.join(baseDir, sourcePath);
@@ -251,11 +253,11 @@ export function setup(testData: WorkflowTestData[] | WorkflowTestData) {
const nodeNames = nodes.map((n) => n.type);
for (const nodeName of nodeNames) {
if (!nodeName.startsWith('n8n-nodes-base.')) {
throw new Error(`Unknown node type: ${nodeName}`);
throw new ApplicationError(`Unknown node type: ${nodeName}`, { level: 'warning' });
}
const loadInfo = knownNodes[nodeName.replace('n8n-nodes-base.', '')];
if (!loadInfo) {
throw new Error(`Unknown node type: ${nodeName}`);
throw new ApplicationError(`Unknown node type: ${nodeName}`, { level: 'warning' });
}
const sourcePath = loadInfo.sourcePath.replace(/^dist\//, './').replace(/\.js$/, '.ts');
const nodeSourcePath = path.join(baseDir, sourcePath);
@@ -283,7 +285,7 @@ export function getResultNodeData(result: IRun, testData: WorkflowTestData) {
}
});
throw new Error(`Data for node "${nodeName}" is missing!`);
throw new ApplicationError(`Data for node "${nodeName}" is missing!`, { level: 'warning' });
}
const resultData = result.data.resultData.runData[nodeName].map((nodeData) => {
if (nodeData.data === undefined) {
@@ -354,7 +356,7 @@ export const workflowToTests = (workflowFiles: string[]) => {
}
});
if (workflowData.pinData === undefined) {
throw new Error('Workflow data does not contain pinData');
throw new ApplicationError('Workflow data does not contain pinData', { level: 'warning' });
}
const nodeData = preparePinData(workflowData.pinData);