admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-21 11:49:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Log binary data file write errors (no-changelog) (#7237)

Browse Source 
This PR adds logging for binary data file write errors, to capture why
executions sometimes point to non-existing binary data files. See
[Sentry
error](https://n8nio.sentry.io/issues/4495134693/?alert_rule_id=14556563&alert_type=issue&notification_uuid=4b50a5da-6ae9-472e-9658-984cca824762&project=4503924908883968&referrer=slack).
This commit is contained in:
Iván Ovejero
2023-09-22 11:48:20 +02:00
committed by GitHub
parent c0df5cdfd4
commit e8e44f6b6e
7 changed files with 54 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/core/src/BinaryDataManager/index.ts
View File

@@ -1,11 +1,13 @@
import { readFile, stat } from 'fs/promises';
import type { BinaryMetadata, IBinaryData, INodeExecutionData } from 'n8n-workflow';
import type { BinaryMetadata, INodeExecutionData } from 'n8n-workflow';
import prettyBytes from 'pretty-bytes';
import type { Readable } from 'stream';
import { BINARY_ENCODING } from 'n8n-workflow';
import type { IBinaryDataConfig, IBinaryDataManager } from '../Interfaces';
import { BINARY_ENCODING, LoggerProxy as Logger, IBinaryData } from 'n8n-workflow';
import { IBinaryDataConfig } from '../Interfaces';
import type { IBinaryDataManager } from '../Interfaces';
import { BinaryDataFileSystem } from './FileSystem';
import { binaryToBuffer } from './utils';
import { LogCatch } from '../decorators/LogCatch.decorator';
export class BinaryDataManager {
static instance: BinaryDataManager | undefined;
@@ -47,6 +49,7 @@ export class BinaryDataManager {
return BinaryDataManager.instance;
}
@LogCatch((error) => Logger.error('Failed to copy binary data file', { error }))
async copyBinaryFile(
binaryData: IBinaryData,
filePath: string,
@@ -79,6 +82,7 @@ export class BinaryDataManager {
return binaryData;
}
@LogCatch((error) => Logger.error('Failed to write binary data file', { error }))
async storeBinaryData(
binaryData: IBinaryData,
input: Buffer | Readable,
@@ -162,6 +166,9 @@ export class BinaryDataManager {
}
}
@LogCatch((error) =>
Logger.error('Failed to copy all binary data files for execution', { error }),
)
async duplicateBinaryData(
inputData: Array<INodeExecutionData[] | null>,
executionId: string,