admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-18 02:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Make the 'set output' node optional if you inserted a 'set metrics' node (no-changelog) (#16955)

Browse Source
This commit is contained in:
jeanpaul
2025-07-04 14:55:23 +02:00
committed by GitHub
parent d754ce922d
commit e982d9144b
7 changed files with 6 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/frontend/@n8n/i18n/src/locales/en.json
View File

@@ -3126,7 +3126,6 @@
"evaluation.listRuns.error.evaluationTriggerNotFound": "Evaluation trigger missing",
"evaluation.listRuns.error.evaluationTriggerNotConfigured": "Evaluation trigger is not configured",
"evaluation.listRuns.error.evaluationTriggerDisabled": "Evaluation trigger is disabled",
"evaluation.listRuns.error.setOutputsNodeNotFound": "No 'Set outputs' node in workflow",
"evaluation.listRuns.error.setOutputsNodeNotConfigured": "'Set outputs' node is not configured",
"evaluation.listRuns.error.setMetricsNodeNotFound": "No 'Set metrics' node in workflow",
"evaluation.listRuns.error.setMetricsNodeNotConfigured": "'Set metrics' node is not configured",

12
packages/frontend/editor-ui/src/components/Evaluations.ee/SetupWizard/SetupWizard.vue
View File

@@ -49,11 +49,7 @@ const initializeActiveStep = () => {
return;
}
if (
evaluationStore.evaluationTriggerExists &&
evaluationStore.evaluationSetOutputsNodeExist &&
evaluationStore.evaluationSetMetricsNodeExist
) {
if (evaluationStore.evaluationTriggerExists && evaluationStore.evaluationSetMetricsNodeExist) {
activeStepIndex.value = 3;
} else if (
evaluationStore.evaluationTriggerExists &&
@@ -241,7 +237,8 @@ function onSeePlans() {
type="secondary"
:disabled="
!evaluationStore.evaluationTriggerExists ||
!evaluationStore.evaluationSetOutputsNodeExist
(!evaluationStore.evaluationSetOutputsNodeExist &&
!evaluationStore.evaluationSetMetricsNodeExist)
"
@click="$emit('runTest')"
>
@@ -253,7 +250,8 @@ function onSeePlans() {
type="secondary"
:disabled="
!evaluationStore.evaluationTriggerExists ||
!evaluationStore.evaluationSetOutputsNodeExist
(!evaluationStore.evaluationSetOutputsNodeExist &&
!evaluationStore.evaluationSetMetricsNodeExist)
"
@click="navigateToWorkflow('executeEvaluation')"
>

1
packages/frontend/editor-ui/src/components/Evaluations.ee/shared/TableStatusCell.vue
View File

@@ -32,7 +32,6 @@ const errorTooltipMap: Record<string, BaseTextKey> = {
TEST_CASES_NOT_FOUND: 'evaluation.listRuns.error.testCasesNotFound',
EVALUATION_TRIGGER_NOT_FOUND: 'evaluation.listRuns.error.evaluationTriggerNotFound',
EVALUATION_TRIGGER_NOT_CONFIGURED: 'evaluation.listRuns.error.evaluationTriggerNotConfigured',
SET_OUTPUTS_NODE_NOT_FOUND: 'evaluation.listRuns.error.setOutputsNodeNotFound',
SET_OUTPUTS_NODE_NOT_CONFIGURED: 'evaluation.listRuns.error.setOutputsNodeNotConfigured',
SET_METRICS_NODE_NOT_FOUND: 'evaluation.listRuns.error.setMetricsNodeNotFound',
SET_METRICS_NODE_NOT_CONFIGURED: 'evaluation.listRuns.error.setMetricsNodeNotConfigured',

2
packages/frontend/editor-ui/src/components/Evaluations.ee/shared/errorCodes.ts
View File

@@ -18,7 +18,6 @@ const TEST_RUN_ERROR_CODES = {
EVALUATION_TRIGGER_NOT_FOUND: 'EVALUATION_TRIGGER_NOT_FOUND',
EVALUATION_TRIGGER_NOT_CONFIGURED: 'EVALUATION_TRIGGER_NOT_CONFIGURED',
EVALUATION_TRIGGER_DISABLED: 'EVALUATION_TRIGGER_DISABLED',
SET_OUTPUTS_NODE_NOT_FOUND: 'SET_OUTPUTS_NODE_NOT_FOUND',
SET_OUTPUTS_NODE_NOT_CONFIGURED: 'SET_OUTPUTS_NODE_NOT_CONFIGURED',
SET_METRICS_NODE_NOT_FOUND: 'SET_METRICS_NODE_NOT_FOUND',
SET_METRICS_NODE_NOT_CONFIGURED: 'SET_METRICS_NODE_NOT_CONFIGURED',
@@ -42,7 +41,6 @@ const testRunErrorDictionary: Partial<Record<TestRunErrorCode, BaseTextKey>> = {
EVALUATION_TRIGGER_NOT_FOUND: 'evaluation.listRuns.error.evaluationTriggerNotFound',
EVALUATION_TRIGGER_NOT_CONFIGURED: 'evaluation.listRuns.error.evaluationTriggerNotConfigured',
EVALUATION_TRIGGER_DISABLED: 'evaluation.listRuns.error.evaluationTriggerDisabled',
SET_OUTPUTS_NODE_NOT_FOUND: 'evaluation.listRuns.error.setOutputsNodeNotFound',
SET_OUTPUTS_NODE_NOT_CONFIGURED: 'evaluation.listRuns.error.setOutputsNodeNotConfigured',
SET_METRICS_NODE_NOT_FOUND: 'evaluation.listRuns.error.setMetricsNodeNotFound',
SET_METRICS_NODE_NOT_CONFIGURED: 'evaluation.listRuns.error.setMetricsNodeNotConfigured',