admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

⚡ Minor improvements to ActiveCampaign-Node

Browse Source
This commit is contained in:
Jan Oberhauser
2020-09-18 09:42:46 +02:00
parent a552febab4
commit ed0f701c6a
3 changed files with 22 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/nodes-base/nodes/ActiveCampaign/ActiveCampaign.node.ts
View File

@@ -474,7 +474,7 @@ export class ActiveCampaign implements INodeType {
} else { } else {
throw new Error(`The operation "${operation}" is not known`); throw new Error(`The operation "${operation}" is not known`);
} }
} else if (resource === 'accountContact') { } else if (resource === 'accountContact') {
if (operation === 'create') { if (operation === 'create') {
// ---------------------------------- // ----------------------------------
// account:create // account:create

2
packages/nodes-base/nodes/ActiveCampaign/ActiveCampaignTrigger.node.ts
View File

@@ -142,7 +142,7 @@ export class ActiveCampaignTrigger implements INodeType {
const webhookData = this.getWorkflowStaticData('node'); const webhookData = this.getWorkflowStaticData('node');
try { try {
await activeCampaignApiRequest.call(this, 'DELETE', `/api/3/webhooks/${webhookData.webhookId}`, {}); await activeCampaignApiRequest.call(this, 'DELETE', `/api/3/webhooks/${webhookData.webhookId}`, {});
} catch(error) { } catch (error) {
return false; return false;
} }
delete webhookData.webhookId; delete webhookData.webhookId;

42
packages/nodes-base/nodes/ActiveCampaign/GenericFunctions.ts
View File

@@ -49,8 +49,6 @@ export async function activeCampaignApiRequest(this: IHookFunctions | IExecuteFu
options.body = body; options.body = body;
} }
console.log(options);
try { try {
const responseData = await this.helpers.request!(options); const responseData = await this.helpers.request!(options);
@@ -127,11 +125,11 @@ export async function activeCampaignApiRequestAllItems(this: IHookFunctions | IE
return returnData; return returnData;
} }
export function activeCampaignDefaultGetAllProperties (resource: string, operation: string): INodeProperties [] { export function activeCampaignDefaultGetAllProperties(resource: string, operation: string): INodeProperties[] {
return [ return [
{ {
displayName: 'Return All', displayName: 'Return All',
name: 'returnAll', name: 'returnAll',
type: 'boolean', type: 'boolean',
displayOptions: { displayOptions: {
show: { show: {
@@ -148,26 +146,26 @@ export function activeCampaignDefaultGetAllProperties (resource: string, operati
}, },
{ {
displayName: 'Limit', displayName: 'Limit',
name: 'limit', name: 'limit',
type: 'number', type: 'number',
displayOptions: { displayOptions: {
show: { show: {
operation: [ operation: [
operation, operation,
], ],
resource: [ resource: [
resource, resource,
], ],
returnAll: [ returnAll: [
false, false,
], ],
},
}, },
}, typeOptions: {
typeOptions: { minValue: 1,
minValue: 1, maxValue: 500,
maxValue: 500, },
}, default: 100,
default: 100,
description: 'How many results to return.', description: 'How many results to return.',
}, },
{ {
@@ -185,7 +183,7 @@ export function activeCampaignDefaultGetAllProperties (resource: string, operati
}, },
}, },
default: true, default: true,
description: 'When set to true a simplify version of the response will be used else the raw data will be used', description: 'When set to true a simplify version of the response will be used else the raw data.',
}, },
]; ];
} }