admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-19 11:01:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Update operations to run per item (#8967)

Browse Source 
Co-authored-by: Elias Meire <elias@meire.dev>
This commit is contained in:
Michael Kret
2024-05-22 15:28:09 +03:00
committed by GitHub
parent 870412f093
commit ef9d4aba90
12 changed files with 611 additions and 442 deletions
Download Patch File Download Diff File Expand all files Collapse all files

119
packages/nodes-base/nodes/RssFeedRead/RssFeedRead.node.ts
View File

@@ -28,7 +28,7 @@ export class RssFeedRead implements INodeType {
name: 'rssFeedRead',
icon: 'fa:rss',
group: ['input'],
version: 1,
version: [1, 1.1],
description: 'Reads data from an RSS Feed',
defaults: {
name: 'RSS Read',
@@ -65,59 +65,88 @@ export class RssFeedRead implements INodeType {
};
async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
const pairedItem = generatePairedItemData(this.getInputData().length);
const returnData: INodeExecutionData[] = [];
const nodeVersion = this.getNode().typeVersion;
const items = this.getInputData();
try {
const url = this.getNodeParameter('url', 0) as string;
const options = this.getNodeParameter('options', 0);
const ignoreSSL = Boolean(options.ignoreSSL);
let itemsLength = items.length ? 1 : 0;
let fallbackPairedItems;
if (!url) {
throw new NodeOperationError(this.getNode(), 'The parameter "URL" has to be set!');
}
if (nodeVersion >= 1.1) {
itemsLength = items.length;
} else {
fallbackPairedItems = generatePairedItemData(items.length);
}
if (!validateURL(url)) {
throw new NodeOperationError(this.getNode(), 'The provided "URL" is not valid!');
}
const parser = new Parser({
requestOptions: {
rejectUnauthorized: !ignoreSSL,
},
});
let feed: Parser.Output<IDataObject>;
for (let i = 0; i < itemsLength; i++) {
try {
feed = await parser.parseURL(url);
} catch (error) {
if (error.code === 'ECONNREFUSED') {
throw new NodeOperationError(
this.getNode(),
`It was not possible to connect to the URL. Please make sure the URL "${url}" it is valid!`,
);
const url = this.getNodeParameter('url', i) as string;
const options = this.getNodeParameter('options', i);
const ignoreSSL = Boolean(options.ignoreSSL);
if (!url) {
throw new NodeOperationError(this.getNode(), 'The parameter "URL" has to be set!', {
itemIndex: i,
});
}
throw new NodeOperationError(this.getNode(), error as Error);
}
const returnData: INodeExecutionData[] = [];
// For now we just take the items and ignore everything else
if (feed.items) {
feed.items.forEach((item) => {
returnData.push({
json: item,
pairedItem,
if (!validateURL(url)) {
throw new NodeOperationError(this.getNode(), 'The provided "URL" is not valid!', {
itemIndex: i,
});
});
}
}
return [returnData];
} catch (error) {
if (this.continueOnFail()) {
return [[{ json: { error: error.message }, pairedItem }]];
const parser = new Parser({
requestOptions: {
rejectUnauthorized: !ignoreSSL,
},
});
let feed: Parser.Output<IDataObject>;
try {
feed = await parser.parseURL(url);
} catch (error) {
if (error.code === 'ECONNREFUSED') {
throw new NodeOperationError(
this.getNode(),
`It was not possible to connect to the URL. Please make sure the URL "${url}" it is valid!`,
{
itemIndex: i,
},
);
}
throw new NodeOperationError(this.getNode(), error as Error, {
itemIndex: i,
});
}
// For now we just take the items and ignore everything else
if (feed.items) {
const feedItems = (feed.items as IDataObject[]).map((item) => ({
json: item,
})) as INodeExecutionData[];
const itemData = fallbackPairedItems || [{ item: i }];
const executionData = this.helpers.constructExecutionMetaData(feedItems, {
itemData,
});
returnData.push(...executionData);
}
} catch (error) {
if (this.continueOnFail()) {
returnData.push({
json: { error: error.message },
pairedItem: fallbackPairedItems || [{ item: i }],
});
continue;
}
throw error;
}
throw error;
}
return [returnData];
}
}