From f0a51a0b7671945b84e18774483dc7079f559845 Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Sat, 1 Apr 2023 19:03:12 +0200 Subject: [PATCH] fix(core): Improve axios error handling in nodes (#5891) --- packages/core/src/NodeExecuteFunctions.ts | 2 +- packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/src/NodeExecuteFunctions.ts b/packages/core/src/NodeExecuteFunctions.ts index 147cc61fb9..804c866845 100644 --- a/packages/core/src/NodeExecuteFunctions.ts +++ b/packages/core/src/NodeExecuteFunctions.ts @@ -707,7 +707,7 @@ async function proxyRequestToAxios( const message = `${response.status as number} - ${JSON.stringify(responseData)}`; throw Object.assign(new Error(message, { cause: error }), { - status: response.status, + statusCode: response.status, options: pick(config ?? {}, ['url', 'method', 'data', 'headers']), }); } else { diff --git a/packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts b/packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts index 791927f979..d5da6c8eb0 100644 --- a/packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts +++ b/packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts @@ -1310,7 +1310,7 @@ export class HttpRequestV3 implements INodeType { if (autoDetectResponseFormat && response.reason.error instanceof Buffer) { response.reason.error = Buffer.from(response.reason.error as Buffer).toString(); } - throw new NodeApiError(this.getNode(), response as JsonObject); + throw new NodeApiError(this.getNode(), response.reason as JsonObject); } else { // Return the actual reason as error returnItems.push({