admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 18:12:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fix problem saving workflow when tags disabled (#3792)

Browse Source 
* ⚡ Add @AfterLoad nullCheck for WorkflowEntity tags

* ⚡ Make tags optional in Entity

* Fix workflows api typing issue

Co-authored-by: Omar Ajoue <krynble@gmail.com>
This commit is contained in:
brianinoa
2022-08-02 17:18:57 +02:00
committed by GitHub
parent 2cab8e7779
commit f0dddaa2a5
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/cli/src/Interfaces.ts
View File

@@ -144,7 +144,7 @@ export interface IWorkflowBase extends IWorkflowBaseWorkflow {
// Almost identical to editor-ui.Interfaces.ts // Almost identical to editor-ui.Interfaces.ts
export interface IWorkflowDb extends IWorkflowBase { export interface IWorkflowDb extends IWorkflowBase {
id: number | string; id: number | string;
tags: ITagDb[]; tags?: ITagDb[];
} }
export interface IWorkflowToImport extends IWorkflowBase { export interface IWorkflowToImport extends IWorkflowBase {

2
packages/cli/src/Server.ts
View File

@@ -993,7 +993,7 @@ class App {
); );
} }
if (updatedWorkflow.tags.length && tags?.length) { if (updatedWorkflow.tags?.length && tags?.length) {
updatedWorkflow.tags = TagHelpers.sortByRequestOrder(updatedWorkflow.tags, { updatedWorkflow.tags = TagHelpers.sortByRequestOrder(updatedWorkflow.tags, {
requestOrder: tags, requestOrder: tags,
}); });

2
packages/cli/src/api/workflows.api.ts
View File

@@ -69,7 +69,7 @@ workflowsController.post(
throw new ResponseHelper.ResponseError('Failed to save workflow'); throw new ResponseHelper.ResponseError('Failed to save workflow');
} }
if (tagIds && !config.getEnv('workflowTagsDisabled')) { if (tagIds && !config.getEnv('workflowTagsDisabled') && savedWorkflow.tags) {
savedWorkflow.tags = TagHelpers.sortByRequestOrder(savedWorkflow.tags, { savedWorkflow.tags = TagHelpers.sortByRequestOrder(savedWorkflow.tags, {
requestOrder: tagIds, requestOrder: tagIds,
}); });

2
packages/cli/src/databases/entities/WorkflowEntity.ts
View File

@@ -112,7 +112,7 @@ export class WorkflowEntity implements IWorkflowDb {
referencedColumnName: 'id', referencedColumnName: 'id',
}, },
}) })
tags: TagEntity[]; tags?: TagEntity[];
@OneToMany(() => SharedWorkflow, (sharedWorkflow) => sharedWorkflow.workflow) @OneToMany(() => SharedWorkflow, (sharedWorkflow) => sharedWorkflow.workflow)
shared: SharedWorkflow[]; shared: SharedWorkflow[];