admin/n8n-enterprise-unlocked
1
0
Fork 0
mirror of https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git synced 2025-12-17 10:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix issue sending tags when creating a conversation (HelpScout) (#1501)

Browse Source
This commit is contained in:
Ricardo Espinoza
2021-03-01 17:38:22 -05:00
committed by GitHub
parent 3ff7d3af39
commit f13a2781a6
5 changed files with 31 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
packages/nodes-base/nodes/HelpScout/HelpScout.node.ts
View File

@@ -59,7 +59,7 @@ export class HelpScout implements INodeType {
description: INodeTypeDescription = {
displayName: 'HelpScout',
name: 'helpScout',
icon: 'file:helpScout.png',
icon: 'file:helpScout.svg',
group: ['input'],
version: 1,
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
@@ -139,7 +139,7 @@ export class HelpScout implements INodeType {
const tagId = tag.id;
returnData.push({
name: tagName,
value: tagId,
value: tagName,
});
}
return returnData;
@@ -391,23 +391,23 @@ export class HelpScout implements INodeType {
}
if (attachments) {
if (attachments.attachmentsValues
&& (attachments.attachmentsValues as IDataObject[]).length !== 0) {
&& (attachments.attachmentsValues as IDataObject[]).length !== 0) {
body.attachments?.push.apply(body.attachments, attachments.attachmentsValues as IAttachment[]);
}
if (attachments.attachmentsBinary
&& (attachments.attachmentsBinary as IDataObject[]).length !== 0
&& items[i].binary) {
const mapFunction = (value: IDataObject): IAttachment => {
const binaryProperty = (items[i].binary as IBinaryKeyData)[value.property as string];
&& (attachments.attachmentsBinary as IDataObject[]).length !== 0
&& items[i].binary) {
const mapFunction = (value: IDataObject): IAttachment => {
const binaryProperty = (items[i].binary as IBinaryKeyData)[value.property as string];
if (binaryProperty) {
return {
fileName: binaryProperty.fileName || 'unknown',
data: binaryProperty.data,
mimeType: binaryProperty.mimeType,
};
} else {
throw new Error(`Binary property ${value.property} does not exist on input`);
}
};
} else {
throw new Error(`Binary property ${value.property} does not exist on input`);
}
};
body.attachments?.push.apply(body.attachments, (attachments.attachmentsBinary as IDataObject[]).map(mapFunction) as IAttachment[]);
}