From f4916c7efbff6ec4f76fb7cd948e3ad7f13ac821 Mon Sep 17 00:00:00 2001 From: Allan Daemon Date: Tue, 13 Apr 2021 13:27:25 -0300 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=EF=B8=8F=20Close=20RabbitMQ=20connect?= =?UTF-8?q?ions=20left=20open=20after=20use=20(#1594)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/nodes-base/nodes/RabbitMQ/RabbitMQ.node.ts | 3 +++ packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts | 1 + 2 files changed, 4 insertions(+) diff --git a/packages/nodes-base/nodes/RabbitMQ/RabbitMQ.node.ts b/packages/nodes-base/nodes/RabbitMQ/RabbitMQ.node.ts index 80a209c4e4..3ce903d913 100644 --- a/packages/nodes-base/nodes/RabbitMQ/RabbitMQ.node.ts +++ b/packages/nodes-base/nodes/RabbitMQ/RabbitMQ.node.ts @@ -355,6 +355,7 @@ export class RabbitMQ implements INodeType { }); await channel.close(); + await channel.connection.close(); } else if (mode === 'exchange') { const exchange = this.getNodeParameter('exchange', 0) as string; @@ -419,6 +420,7 @@ export class RabbitMQ implements INodeType { }); await channel.close(); + await channel.connection.close(); } else { throw new Error(`The operation "${mode}" is not known!`); } @@ -428,6 +430,7 @@ export class RabbitMQ implements INodeType { catch (error) { if (channel) { await channel.close(); + await channel.connection.close(); } throw error; } diff --git a/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts b/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts index f39cacf080..3cb586dc59 100644 --- a/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts +++ b/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts @@ -151,6 +151,7 @@ export class RabbitMQTrigger implements INodeType { // the workflow gets deactivated and can so clean up. async function closeFunction() { await channel.close(); + await channel.connection.close(); } // The "manualTriggerFunction" function gets called by n8n