refactor: Add rule no-constant-binary-expression (no-changelog) (#7670)

https://eslint.org/docs/latest/rules/no-constant-binary-expression
This commit is contained in:
Iván Ovejero
2023-11-09 17:50:59 +01:00
committed by GitHub
parent 40dc5a0d85
commit f73a0597ba
11 changed files with 23 additions and 11 deletions

View File

@@ -147,9 +147,11 @@ export const loadPublicApiVersions = async (
}),
);
const version = versions.pop()?.charAt(1);
return {
apiRouters,
apiLatestVersion: Number(versions.pop()?.charAt(1)) ?? 1,
apiLatestVersion: version ? Number(version) : 1,
};
};

View File

@@ -174,7 +174,9 @@ export class SourceControlGitService {
}
}
await this.setGitUserDetails(
`${user.firstName} ${user.lastName}` ?? SOURCE_CONTROL_DEFAULT_NAME,
user.firstName && user.lastName
? `${user.firstName} ${user.lastName}`
: SOURCE_CONTROL_DEFAULT_NAME,
user.email ?? SOURCE_CONTROL_DEFAULT_EMAIL,
);
if (sourceControlPreferences.initRepo) {