refactor: Add rule no-constant-binary-expression (no-changelog) (#7670)

https://eslint.org/docs/latest/rules/no-constant-binary-expression

packages/nodes-base/nodes/ClickUp/ClickUp.node.ts

@@ -743,7 +743,7 @@ export class ClickUp implements INodeType {
 						) {
 							if (
 								additionalFields.stepsStart === undefined ||
-								!additionalFields.stepsEnd === undefined
+								additionalFields.stepsEnd === undefined
 							) {
 								throw new NodeOperationError(
 									this.getNode(),

packages/nodes-base/nodes/HaloPSA/GenericFunctions.ts

@@ -96,7 +96,7 @@ export async function haloPSAApiRequest(
 		return result;
 	} catch (error) {
 		const message = (error as JsonObject).message as string;
-		if (method === 'DELETE' || 'GET' || ('UPDATE' && message)) {
+		if (method === 'DELETE' || method === 'GET' || (method === 'UPDATE' && message)) {
 			let newErrorMessage;
 			if (message.includes('400')) {
 				console.log(message);

packages/nodes-base/nodes/Odoo/GenericFunctions.ts

@@ -235,7 +235,7 @@ export async function odooGet(
 					password,
 					mapOdooResources[resource] || resource,
 					mapOperationToJSONRPC[operation],
-					[+itemsID] || [],
+					itemsID ? [+itemsID] : [],
 					fieldsToReturn || [],
 				],
 			},
@@ -326,7 +326,7 @@ export async function odooUpdate(
 					password,
 					mapOdooResources[resource] || resource,
 					mapOperationToJSONRPC[operation],
-					[+itemsID] || [],
+					itemsID ? [+itemsID] : [],
 					fieldsToUpdate,
 				],
 			},
@@ -369,7 +369,7 @@ export async function odooDelete(
 					password,
 					mapOdooResources[resource] || resource,
 					mapOperationToJSONRPC[operation],
-					[+itemsID] || [],
+					itemsID ? [+itemsID] : [],
 				],
 			},
 			id: Math.floor(Math.random() * 100),

packages/nodes-base/utils/utilities.ts

@@ -84,7 +84,7 @@ export function updateDisplayOptions(
 
 export function processJsonInput<T>(jsonData: T, inputName?: string) {
 	let values;
-	const input = `'${inputName}' ` || '';
+	const input = inputName ? `'${inputName}' ` : '';
 
 	if (typeof jsonData === 'string') {
 		try {