fix(Wait Node): Authentication fix (#10236)

This commit is contained in:
Michael Kret
2024-07-30 15:43:05 +03:00
committed by GitHub
parent d6770b5fca
commit f87854f8db
2 changed files with 41 additions and 6 deletions

View File

@@ -237,6 +237,14 @@ export class Wait extends Webhook {
inputs: ['main'],
outputs: ['main'],
credentials: credentialsProperty(this.authPropertyName),
hints: [
{
message:
"When testing your workflow using the Editor UI, you can't see the rest of the execution following the Wait node. To inspect the execution results, enable Save Manual Executions in your Workflow settings so you can review the execution results there.",
location: 'outputPane',
whenToDisplay: 'beforeExecution',
},
],
webhooks: [
{
...defaultWebhookDescription,
@@ -294,6 +302,29 @@ export class Wait extends Webhook {
default: 'timeInterval',
description: 'Determines the waiting mode to use before the workflow continues',
},
{
displayName: 'Authentication',
name: 'incomingAuthentication',
type: 'options',
options: [
{
name: 'Basic Auth',
value: 'basicAuth',
},
{
name: 'None',
value: 'none',
},
],
default: 'none',
description:
'If and how incoming resume-webhook-requests to $execution.resumeFormUrl should be authenticated for additional security',
displayOptions: {
show: {
resume: ['form'],
},
},
},
{
...authenticationProperty(this.authPropertyName),
description:
@@ -427,7 +458,7 @@ export class Wait extends Webhook {
async webhook(context: IWebhookFunctions) {
const resume = context.getNodeParameter('resume', 0) as string;
if (resume === 'form') return await formWebhook(context);
if (resume === 'form') return await formWebhook(context, this.authPropertyName);
return await super.webhook(context);
}