mirror of
https://github.com/Abdulazizzn/n8n-enterprise-unlocked.git
synced 2025-12-20 11:22:15 +00:00
fix(core): Handle empty keys in cache service (no-changelog) (#6854)
* fix handle empty keys in cache service * add test * add cache mock test * add simpler mocking, and add tests for all the updated methods * don't use RedisStore specifically in the mock --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
committed by
GitHub
parent
5ab30fdd95
commit
fdfc6c5a92
67
packages/cli/test/unit/services/cache-mock.service.test.ts
Normal file
67
packages/cli/test/unit/services/cache-mock.service.test.ts
Normal file
@@ -0,0 +1,67 @@
|
||||
import Container from 'typedi';
|
||||
import { mock } from 'jest-mock-extended';
|
||||
import { CacheService } from '@/services/cache.service';
|
||||
|
||||
const cacheService = Container.get(CacheService);
|
||||
const store = mock<NonNullable<CacheService['cache']>['store']>({ isCacheable: () => true });
|
||||
Object.assign(cacheService, { cache: { store } });
|
||||
|
||||
describe('CacheService (Mock)', () => {
|
||||
beforeEach(() => jest.clearAllMocks());
|
||||
|
||||
describe('should prevent use of empty keys', () => {
|
||||
test('get', async () => {
|
||||
await cacheService.get('');
|
||||
expect(store.get).not.toHaveBeenCalled();
|
||||
|
||||
await cacheService.get('key');
|
||||
expect(store.get).toHaveBeenCalledWith('key');
|
||||
});
|
||||
|
||||
test('getMany', async () => {
|
||||
await cacheService.getMany([]);
|
||||
expect(store.mget).not.toHaveBeenCalled();
|
||||
|
||||
await cacheService.getMany(['key1', 'key2']);
|
||||
expect(store.mget).toHaveBeenCalledWith('key1', 'key2');
|
||||
});
|
||||
|
||||
test('set', async () => {
|
||||
await cacheService.set('', '');
|
||||
expect(store.set).not.toHaveBeenCalled();
|
||||
|
||||
await cacheService.set('key', 'value');
|
||||
expect(store.set).toHaveBeenCalledWith('key', 'value', undefined);
|
||||
|
||||
await cacheService.set('key', 'value', 123);
|
||||
expect(store.set).toHaveBeenCalledWith('key', 'value', 123);
|
||||
});
|
||||
|
||||
test('setMany', async () => {
|
||||
await cacheService.setMany([]);
|
||||
expect(store.mset).not.toHaveBeenCalled();
|
||||
|
||||
await cacheService.setMany([['key', 'value']]);
|
||||
expect(store.mset).toHaveBeenCalledWith([['key', 'value']], undefined);
|
||||
|
||||
await cacheService.setMany([['key', 'value']], 123);
|
||||
expect(store.mset).toHaveBeenCalledWith([['key', 'value']], 123);
|
||||
});
|
||||
|
||||
test('delete', async () => {
|
||||
await cacheService.delete('');
|
||||
expect(store.del).not.toHaveBeenCalled();
|
||||
|
||||
await cacheService.delete('key');
|
||||
expect(store.del).toHaveBeenCalledWith('key');
|
||||
});
|
||||
|
||||
test('deleteMany', async () => {
|
||||
await cacheService.deleteMany([]);
|
||||
expect(store.mdel).not.toHaveBeenCalled();
|
||||
|
||||
await cacheService.deleteMany(['key1', 'key2']);
|
||||
expect(store.mdel).toHaveBeenCalledWith('key1', 'key2');
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user