Elias Meire
071e6d6b6e
feat(editor): Add fullscreen view to code editor ( #8084 )
...
## Summary
<img width="1240" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a ">
<img width="2649" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe ">
1. Add code node and open it
3. Click the fullscreen button in the bottom right
4. A fullscreen dialog should appear and allow editing the code
5. Changes made in the fullscreen dialog should be applied to the
original code editor when closed
It should work the same way for HTML/SQL/JSON editors
⚠️ Modal layout was updated so that modals/dialogs are centered, try to
test some modals
## Related tickets and issues
https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
> A feature is not complete without tests.
---------
Co-authored-by: Giulio Andreini <andreini@netseven.it >
2024-01-04 17:23:24 +01:00
कारतोफ्फेलस्क्रिप्ट™
216ec079c9
feat(editor): Create separate components for JS and JSON editors (no-changelog) ( #8156 )
...
## Summary
This is part-1 of refactoring our code editors to extract different type
of editors into their own components.
In part-2 we'll
1. delete a of unused or duplicate code
2. switch to a `useEditor` composable to bring more UX consistency
across all the code editors.
## Review / Merge checklist
- [x] PR title and summary are descriptive
- [x] Tests included
2023-12-29 10:49:27 +01:00
कारतोफ्फेलस्क्रिप्ट™
cf7f6688ba
fix(editor): Enable explicit undo keyboard shortcut across all code editors ( #8178 )
...
Fixes [ADO-801](https://linear.app/n8n/issue/ADO-801 ),
[PAY-632](https://linear.app/n8n/issue/PAY-632 ), and
[PAY-730](https://linear.app/n8n/issue/PAY-730 )
Also fixes #5297
## Review / Merge checklist
- [x] PR title and summary are descriptive
2023-12-28 14:55:23 +01:00
कारतोफ्फेलस्क्रिप्ट™
68cff4c59e
refactor(editor): Improve linting for component and prop names (no-changelog) ( #8169 )
2023-12-28 09:49:58 +01:00
कारतोफ्फेलस्क्रिप्ट™
00a4b8b0c6
feat(core): Add support for building LLM applications ( #7235 )
...
This extracts all core and editor changes from #7246 and #7137 , so that
we can get these changes merged first.
ADO-1120
[DB Tests](https://github.com/n8n-io/n8n/actions/runs/6379749011 )
[E2E Tests](https://github.com/n8n-io/n8n/actions/runs/6379751480 )
[Workflow Tests](https://github.com/n8n-io/n8n/actions/runs/6379752828 )
---------
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com >
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com >
Co-authored-by: Alex Grozav <alex@grozav.com >
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in >
2023-10-02 17:33:43 +02:00
Iván Ovejero
832d08776c
fix(editor): Fix formatting on editors (no-changelog) ( #6953 )
...
Prettier 3 has a [new package
structure](https://prettier.io/blog/2023/07/05/3.0.0.html#npm-package-file-structures-changed-12740httpsgithubcomprettierprettierpull12740-by-fiskerhttpsgithubcomfisker-13530httpsgithubcomprettierprettierpull13530-by-fiskerhttpsgithubcomfisker-14570httpsgithubcomprettierprettierpull14570-by-fiskerhttpsgithubcomfisker ),
made `format` async, and requires `estree` in specific cases.
e2e run: https://github.com/n8n-io/n8n/actions/runs/5889270624
2023-08-17 12:28:32 +02:00
Milorad FIlipović
90e825f743
fix(editor): Fix value syncing in SQL and HTML editor ( #6848 )
2023-08-04 10:50:47 +02:00
Alex Grozav
dd6a4c956a
feat(editor): Migrate Design System and Editor UI to Vue 3 ( #6476 )
...
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571 )
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
* fix(editor): Fix loading in production mode [Vue 3] (#6578 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579 )
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697 )
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716 )
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576 )
Co-authored-by: Alex Grozav <alex@grozav.com >
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744 )
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742 )
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743 )
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748 )
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
Co-authored-by: Alex Grozav <alex@grozav.com >
* fix(editor): Some css fixes for vue3 branch (#6749 )
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750 )
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752 )
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753 )
* fix: removed console.log (#6754 )
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755 )
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
Co-authored-by: Alex Grozav <alex@grozav.com >
* fix(editor): Fix `ResourceMapper` unit tests (#6758 )
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760 )
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764 )
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f1448861df021be041b61c62f1e3118
* fix: lint
* fix(editor): Fix collapsed sub menu
* fix: Fix drawer animation (#6767 )
fix: drawer animation
* fix(editor): Fix source control buttons (#6769 )
* fix(editor): Fix App loading & auth (#6768 )
* fix(editor): Fix App loading & auth
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
* Await promises
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
* Fix eslint error
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
Co-authored-by: Csaba Tuncsik <csaba@n8n.io >
Co-authored-by: OlegIvaniv <me@olegivaniv.com >
Co-authored-by: Milorad FIlipović <milorad@n8n.io >
Co-authored-by: Iván Ovejero <ivov.src@gmail.com >
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com >
2023-07-28 09:51:07 +02:00
Milorad FIlipović
c3455a4ad8
feat(editor): Removing ph-no-capture class from some elements ( #6674 )
...
* feat(editor): Remove `.ph-no-capture` class from some of the fields
* ✔️ Updating test snapshots
* ⚡ Redacting expressions preview in credentials form
* 🔧 Disable posthog input masking
* 🚨 Testing PostHog iFrame settings
* Reverting iframe test
* ⚡ Hiding API key in PostHog recordings
* ✅ Added tests for redacted values
* ✔️ Updating checkbox snapshots after label component update
* ✔️ Updating test snapshots in editor-ui
* 👕 Fix lint errors
2023-07-19 16:51:49 +02:00
कारतोफ्फेलस्क्रिप्ट™
ebb3aaf61e
refactor(editor): Drop vue-typed-mixins (no-changelog) ( #6257 )
2023-05-16 11:43:46 +02:00
Iván Ovejero
57aab63c10
refactor: Integrate consistent-type-imports in FE packages (no-changelog) ( #6060 )
...
* 👕 Move `consistent-type-imports` to top level
* 👕 Apply lintfixes
* 👕 Apply more lintfixes
* 👕 More lintfixes
* 👕 More lintfixes
2023-04-24 12:18:24 +02:00
Alex Grozav
54f99a7d0d
feat: Replace this.$refs.refName as Vue with InstanceType<T> (no-changelog) ( #6050 )
...
* refactor: use InstanceType<T> for all this.$refs types
* refactor: update refs type in N8nSelect
* fix: remove inputRef non-null assertion
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com >
* fix: remove non-null assertion
---------
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com >
2023-04-21 16:59:04 +03:00
Alex Grozav
5651a52364
feat: Replace new Vue() with custom event bus (no-changelog) ( #5780 )
...
* refactor: replace new Vue() with custom event bus (no-changelog)
* fix: export types from design system main
* fix: update component types
* fix: update form inputs event bus
2023-04-06 16:32:45 +03:00
Milorad FIlipović
cd7a55ba5a
fix(editor): Fix redo in code and expression editor ( #5708 )
...
* fix(editor): Fix redo in code and expression editor
* ⚡ Updating keymap to use platform-specific command key
2023-03-17 13:23:49 +01:00
Iván Ovejero
a07de049a2
feat(editor): Bring completions to HTML editor ( #5382 )
...
⚡ Bring completions to HTML editor
2023-02-09 09:41:07 +01:00
Iván Ovejero
8b09e98654
feat(editor): Adjust HTML editor component for use in params ( #5285 )
...
* ✨ Adjust HTML editor component
* ♻️ Apply feedback
* ♻️ Apply feedback
* 🔥 Remove unused ndv store refs
2023-02-02 14:00:16 +01:00
Iván Ovejero
74e6f5d190
feat: HTML node ( #5107 )
...
* ✨ Create HTML templating node PoC
* ♻️ Apply feedback
* 🐛 Scope CSS selectors
* ✏️ Adjust description
* ✏️ Adjust placeholder
* ⚡ Replace two custom files with package output
* ➕ Add `codemirror-lang-html-n8n`
* 👕 Appease linter
* 🧪 Skip event bus tests
* ⏪ Revert "Skip event bus tests"
This reverts commit 5702585d0de3b8465660567132e9003e78f1104c.
* ✏️ Update codex
* 🧹 Cleanup
* 🐛 Restore original for `continueOnFail`
* ⚡ Improve `getResolvables`
2023-01-26 10:03:13 +01:00
