Commit Graph

9 Commits

Author SHA1 Message Date
Dana
0d5ac1f822 fix(HTTP Request Node): Process text files (#16226) 2025-06-13 15:05:15 +01:00
कारतोफ्फेलस्क्रिप्ट™
979f9e6327 refactor: Overhaul nodes-testing setup - Part 3 (no-changelog) (#14967) 2025-04-29 17:42:21 +02:00
कारतोफ्फेलस्क्रिप्ट™
91069f057e refactor: Overhaul nodes-testing setup - Part 2 (no-changelog) (#14873) 2025-04-24 17:37:26 +02:00
कारतोफ्फेलस्क्रिप्ट™
73e8d76e13 refactor: Overhaul nodes-testing setup - Part 1 (no-changelog) (#14303) 2025-04-01 10:15:13 +02:00
कारतोफ्फेलस्क्रिप्ट™
f64c6bf9ac chore: Upgrade nock and delete nock related boilerplate code (no-changelog) (#12869) 2025-01-27 18:17:51 +01:00
कारतोफ्फेलस्क्रिप्ट™
bafac73eb5 refactor: Impose import/order linting rule across nodes packages (no-changelog) (#12314) 2024-12-19 18:46:14 +01:00
Tomi Turtiainen
9a1cc56806 fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) (#8363)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-17 17:08:50 +02:00
Iván Ovejero
6d6e2488c6 refactor(core): Generalize binary data manager interface (no-changelog) (#7164)
Depends on: #7092 | Story:
[PAY-768](https://linear.app/n8n/issue/PAY-768)

This PR: 
- Generalizes the `IBinaryDataManager` interface.
- Adjusts `Filesystem.ts` to satisfy the interface.
- Sets up an S3 client stub to be filled in in the next PR.
- Turns `BinaryDataManager` into an injectable service.
- Adjusts the config schema and adds new validators.

Note that the PR looks large but all the main changes are in
`packages/core/src/binaryData`.

Out of scope:
- `BinaryDataManager` (now `BinaryDataService`) and `Filesystem.ts` (now
`fs.client.ts`) were slightly refactored for maintainability, but fully
overhauling them is **not** the focus of this PR, which is meant to
clear the way for the S3 implementation. Future improvements for these
two should include setting up a backwards-compatible dir structure that
makes it easier to locate binary data files to delete, removing
duplication, simplifying cloning methods, using integers for binary data
size instead of `prettyBytes()`, writing tests for existing binary data
logic, etc.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-22 17:22:12 +02:00
कारतोफ्फेलस्क्रिप्ट™
273d0913fe feat(HTTP Request Node): Determine binary file name from content-disposition headers (#7032)
Fixes: 

https://community.n8n.io/t/http-request-node-read-filename-from-content-disposition-header-when-downloading-files/13453

https://community.n8n.io/t/read-filename-from-content-disposition-header-when-downloading-files/22192
2023-09-06 12:38:37 +02:00