Commit Graph

54 Commits

Author SHA1 Message Date
Omar Ajoue
0e9a5a2ab2 fix: Properly iterate over credentials with expressions (#8502) 2024-01-31 13:12:18 +01:00
Iván Ovejero
d4c93b1607 fix(core): Prevent issues with missing or mismatching encryption key (#8332) 2024-01-16 18:25:53 +01:00
कारतोफ्फेलस्क्रिप्ट™
05c43faa2d fix(HTTP Request Node): Delete response.request only when it's a valid circular references (#8293) 2024-01-10 18:05:19 +01:00
Jan Oberhauser
ccb2b076f8 fix: Resolve expressions in credentials following paired item (#8250)
## Summary
Fixes the issue that pairedItem information was not available in
expressions that got used in credentials


## Related tickets and issues

[PAY-1207](https://linear.app/n8n/issue/PAY-1207/paireditem-expressions-not-working-correctly-in-credentials)


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
2024-01-08 09:48:20 +00:00
Michael Kret
270328ccf6 feat(HTTP Request Node): Interval Between Requests option for pagination (#8224)
## Summary
Option to add delay between request when using pagination

![image](https://github.com/n8n-io/n8n/assets/88898367/df93f9c7-2569-4d22-a719-494d9dfe8030)

## Related tickets and issues

https://linear.app/n8n/issue/NODE-1029/http-request-pagination-feature-doesnt-use-batch-settings
https://github.com/n8n-io/n8n/issues/8062
2024-01-04 17:11:16 +02:00
Michael Kret
5e16dd4ab4 feat(core): Improvements/overhaul for nodes working with binary data (#7651)
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Marcus <marcus@n8n.io>
2024-01-03 13:08:16 +02:00
कारतोफ्फेलस्क्रिप्ट™
5b7ea16d9a fix(HTTP Request Node): Do not create circular references in HTTP request node output (#8030)
## Summary
Remove unused `response.request` circular reference in http response
objects

## Related tickets
[PAY-1119](https://linear.app/n8n/issue/PAY-1119)

## Review / Merge checklist
- [x] PR title and summary are descriptive.
2023-12-15 16:40:39 +01:00
Marcus
6208af07eb fix(HTTP Request Node): Enable expressions for binary input data fields (#7782)
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7775
2023-11-23 11:58:50 +01:00
Elias Meire
48b240b026 fix(HTTP Request Node): Support generic credentials when using pagination (#7686)
Github issue / Community forum post (link here to close automatically):
fixes #7653

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-15 09:13:33 +01:00
कारतोफ्फेलस्क्रिप्ट™
ff279ab411 feat(HTTP Request Node): Update icon and default color (#7572)
extracted from https://github.com/n8n-io/n8n/pull/7157

Co-authored-by: Elias Meire <elias@meire.dev>
2023-11-01 17:35:47 +01:00
Jan Oberhauser
cc2bd2e19c feat(HTTP Request Node): Add pagination support (#5993)
Is still WIP and does not implement the correct UI yet.

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/pagination-included-into-http-node/15080

https://community.n8n.io/t/how-to-paginate-through-data-in-http-requests/28103
2023-11-01 14:24:43 +01:00
Iván Ovejero
62c096710f refactor: Run lintfix (no-changelog) (#7537)
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Marcus
0bc33b1cc2 fix(HTTP Request Node): Add suggestion how to fix '429 - too many requests' errors (#7293)
Github issue / Community forum post (link here to close automatically):
2023-09-28 16:00:45 +02:00
Iván Ovejero
75541e91f2 refactor(core)!: Make getBinaryStream async (#7247)
Story: [PAY-846](https://linear.app/n8n/issue/PAY-846) | Related:
https://github.com/n8n-io/n8n/pull/7225

For the S3 backend for external storage of binary data and execution
data, the `getAsStream` method in the binary data manager interface used
by FS and S3 will need to become async. This is a breaking change for
nodes-base.
2023-09-25 16:59:45 +02:00
Elias Meire
321780d4a2 fix(HTTP Request Node): Decrease default timeout to 5min (#7177)
Github issue / Community forum post (link here to close automatically):

fixes https://github.com/n8n-io/n8n/issues/7081
2023-09-20 12:38:34 +02:00
कारतोफ्फेलस्क्रिप्ट™
273d0913fe feat(HTTP Request Node): Determine binary file name from content-disposition headers (#7032)
Fixes: 

https://community.n8n.io/t/http-request-node-read-filename-from-content-disposition-header-when-downloading-files/13453

https://community.n8n.io/t/read-filename-from-content-disposition-header-when-downloading-files/22192
2023-09-06 12:38:37 +02:00
कारतोफ्फेलस्क्रिप्ट™
6aa7b93473 refactor(core): Deprecate prepareOutputData (no-changelog) (#7091) 2023-09-05 12:59:02 +02:00
Romain Dunand
aecc05b787 fix(HTTP Request Node): Cleanup circular references in response (#6590)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-07-12 12:31:32 +02:00
Marcus
b17b4582a0 feat(HTTP Request Node): New http request generic custom auth credential (#5798) 2023-06-29 15:27:02 +02:00
Iván Ovejero
beedfb609c feat(editor): SQL editor overhaul (#6282)
* Draft setup
*  Implemented expression evaluation in Postgres node, minor SQL editor UI improvements, minor refacring
*  Added initial version of expression preview for SQL editor
*  Linking npm package for codemirror sql grammar instead of a local file
*  Moving expression editor wrapper elements to the component
*  Using expression preview in SQL editor
* Use SQL parser skipping whitespace
*  Added support for custom skipped segments specification
*  Fixing highlight problems with dots and expressions that resolve to zero
* 👕 Fixing linting error
*  Added current item support
*  Added expression support to more nodes with sql editor
*  Added expression support for other nodes
*  Implemented different SQL dialect support
* 🐛 Fixing hard-coded parameter names for editors
*  Fixing preview for nested queries, updating query when input data changes, adding keyboard shortcut to toggle comments
*  Adding a custom automcomplete notice for different editors
*  Updating SQL autocomplete notice
*  Added unit tests for SQL editor
*  Using latest grammar
* 🐛 Fixing code node editor rendering
* 💄 SQL preview dropdown matches editor width. Removing unnecessary css
*  Addressing PR review feedback
* 👌 Addressing PR review feedback pt2
* 👌 Added path alias for utils in nodes-base package
* 👌 Addressing more PR review feedback
*  Adding tests for `getResolvables` utility function
* Fixing lodash imports
* 👌 Better focus handling, adding more plugins to the editor, other minor imrovements
*  Not showing SQL autocomplete suggestions inside expressions
*  Using npm package for sql grammar
*  Removing autocomplete notice, adding line highlight on syntax error
* 👌 Addressing code review feedback
---------
Co-authored-by: Milorad Filipovic <milorad@n8n.io>
2023-06-22 16:47:28 +02:00
Michael Kret
d431117c9e feat(HTTP Request Node): Notice about dev console (#6516) 2023-06-22 16:30:04 +03:00
agobrech
3f5c606254 fix(HTTP Request Node): Correctly doesn't redirect on non GET method (#6132)
Fixed ingnored parameter for redirect
2023-05-04 09:55:35 +02:00
Cornelius Suermann
af097ae22c fix(HTTP Request Node): Add description for 'Specify Body' option (#6114)
* fix(HTTP Request Node): Add description for 'Specify Body' option

* disable linting for node-param-description-miscased-json
2023-04-27 17:33:38 +02:00
Michael Kret
983e6e124e fix(HTTP Request Node): Always lowercase headers 2023-04-27 13:36:02 +03:00
Jan Oberhauser
b351c62659 fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991) 2023-04-18 11:48:38 +02:00
Michael Kret
0b48088296 feat(core): Support for google service account in HTTP node 2023-04-14 13:39:52 +03:00
कारतोफ्फेलस्क्रिप्ट™
e79679c023 fix(HTTP Request Node): Show detailed error message in the UI again (#5959) 2023-04-12 14:58:05 +02:00
agobrech
f7e610b15c feat(HTTP Request Node): Follow redirects by default (#5895)
* Redirect as default behaviour

* Remove console.logs

* Move logic to one single variable

* Revert "Redirect as default behaviour"

This reverts commit 5b2221b800297865224384eb7f417d72b0d2bbc1.

* Redirect as default behaviour inside node structure

* Add default behaviour
2023-04-05 15:37:14 +02:00
कारतोफ्फेलस्क्रिप्ट™
a260c05fa8 fix(core): Improve axios error handling in nodes (#5891) 2023-04-03 18:37:22 +02:00
Michael Kret
b29cf9a249 fix(HTTP Request Node): Support for dot notation in JSON body 2023-03-31 19:31:03 +03:00
agobrech
199a91b398 fix(HTTP Request Node): Add streaming to binary response (#5701)
Revert "fix(HTTP Request Node): Remove streaming response  (#5663)"

This reverts commit 8a21fefbc6.
2023-03-21 15:03:47 +01:00
agobrech
8a21fefbc6 fix(HTTP Request Node): Remove streaming response (#5663)
Remove useStream option from requestOptions
2023-03-10 11:54:26 +01:00
कारतोफ्फेलस्क्रिप्ट™
7a4e9ef5fa refactor: Remove n8n-core dependency in nodes-base (no-changelog) (#5649) 2023-03-09 18:13:15 +01:00
agobrech
ce0d9d2bed feat(HTTP Request Node): Move from Binary Buffer to Binary streaming (#5610)
*  Change from binary buffer to binary streaming

* Remove console.logs

* Import Readable from the correct lib

* stream response

* parametersToKeyValue doesn't need to be async anymore

* Fix bodyParameter reduce method

* parametersToKeyValue doesn't need to be async anymore

* handle streaming responses

* send `Content-Length` and `Content-Type` on binary requests

* Add new helper function for binary data

* Add binary function to helpers interface

* Fix bug in error handler

* Fix issue with wrongfully assigned headers to body

* Fix test workflow

* Remove console.logs

* Remove unnecsessary type

* Remove concat dependency already imported in workflow package

* Update pnpm-lock file

* Small fixes, asyncronous error message

* reset the lockfile

* Remove buffer check and simplify error handling

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-03-09 15:38:54 +01:00
कारतोफ्फेलस्क्रिप्ट™
5eb0d52459 refactor: Unify binary-data assertion across all nodes (no-changelog) (#5624) 2023-03-06 17:33:32 +01:00
कारतोफ्फेलस्क्रिप्ट™
3c57062571 refactor: Fix some typos (no-changelog) (#5616) 2023-03-03 18:49:19 +01:00
कारतोफ्फेलस्क्रिप्ट™
4e244937c9 refactor: catch doesn't need to have a param (no-changelog) (#5614) 2023-03-03 18:18:49 +01:00
Michael Kret
bb4db58819 fix(core): Remove linting exceptions in nodes-base, @typescript-eslint/no-unsafe-argument (no-changelog) 2023-02-28 05:39:43 +02:00
feelgood-interface
af703371fc fix(HTTP Request Node): Ignore empty body for auto detect json (#5215) 2023-02-16 11:00:06 +00:00
Iván Ovejero
b03e358a12 refactor: Integrate consistent-type-imports in nodes-base (no-changelog) (#5267)
* 👕 Enable `consistent-type-imports` for nodes-base

* 👕 Apply to nodes-base

*  Undo unrelated changes

* 🚚 Move to `.eslintrc.js` in nodes-base

*  Revert "Enable `consistent-type-imports` for nodes-base"

This reverts commit 529ad72b051478fa1633aaf84b2864f2fdc7613c.

* 👕 Fix severity
2023-01-27 12:22:44 +01:00
Michael Kret
8f49f494ae fix(HTTP Request Node): Bug - node requires string instead of json 2023-01-19 11:34:36 +02:00
Michael Kret
8dbe6159d0 fix(HTTP Request Node): Response format to text is ignored for JSON responses 2023-01-18 15:31:39 +02:00
Iván Ovejero
d9b98fc8be refactor: Lint for no unneeded backticks (#5057) (no-changelog)
*  Create rule `no-unneeded-backticks`

* 👕 Enable rule

*  Run rule on `cli`

*  Run rule on `core`

*  Run rule on `workflow`

*  Rule rule on `design-system`

*  Run rule on `node-dev`

*  Run rule on `editor-ui`

*  Run rule on `nodes-base`
2022-12-29 12:20:43 +01:00
Jan Oberhauser
afc529799d fix(core): Do not send credentials to browser console (#5031) 2022-12-23 23:25:59 +01:00
Michael Kret
61e26804ba refactor(core): Remove linting exceptions in nodes-base (#4794)
*  enabled array-type

*  await-thenable on

*  ban-types on

*  default-param-last on

*  dot-notation on

*  member-delimiter-style on

*  no-duplicate-imports on

*  no-empty-interface on

*  no-floating-promises on

*  no-for-in-array on

*  no-invalid-void-type on

*  no-loop-func on

*  no-shadow on

*  ban-ts-comment re enabled

*  @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-12-02 21:54:28 +01:00
Iván Ovejero
cfd32d2642 refactor: Phase out TSLint in nodes-base (no-changelog) (#4798)
* 🔥 Remove TSLint scripts

* 🔥 Remove TSLint config

* 🔥 Remove TSLint exceptions

* 👕 Adjust lint config

* ✏️ Add story numbers
2022-12-02 15:25:21 +01:00
कारतोफ्फेलस्क्रिप्ट™
2425c10b2b feat(API): Report unhandled app crashes to Sentry (#4548)
* SIGTERM/SIGINT should only be handled once

* move error-handling initialization to commands

* create a new `sleep` function in workflow utils

* detect crashes and report them to Sentry
2022-11-08 17:06:00 +01:00
Ricardo Espinoza
39d4bb2639 fix(HTTP Request Node): use the data in "Put Output in Field" field (#4487)
🐛 Use the data in "Put Output in Field" field
;
2022-11-04 10:50:38 -04:00
Jan Oberhauser
44ad249827 fix(HTTP Request Node): Fix sending previously selected credentials (#4457) 2022-10-27 13:55:04 +02:00
Michael Kret
1d57b10942 refactor(core): fix for no-uncaught-json-parse warnings 2022-10-21 21:52:43 +03:00