Commit Graph

60 Commits

Author SHA1 Message Date
Elias Meire
3add0b82ba fix(Postgres Node): Fix inserting null or undefined in type=json columns (#14672) 2025-04-16 16:36:23 +02:00
Michael Kret
f85b851851 feat(Postgres Node): Batching warning for executeQuery operation insert query (#14287) 2025-04-01 10:57:26 +03:00
Alex Grozav
8215e0b59f refactor: Migrate NodeConnectionType to const object type (no-changelog) (#14078)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2025-03-21 14:01:26 +02:00
Michael Kret
b5632545c5 fix(Postgres Node): RMC do not mark collumn as required if identity_generation is BY DEFAULT (#13752)
Co-authored-by: Dana <152518854+dana-gill@users.noreply.github.com>
2025-03-13 07:35:50 +02:00
Dana
6c266acced fix(Postgres Node): Accommodate null values in query parameters for expressions (#13544) 2025-02-27 16:39:08 +01:00
Shireen Missi
2ef6f111d0 fix: Manually reverted PR 11716 Do not assign all paired items (no-changelog) (#13429) 2025-02-21 19:38:35 +00:00
कारतोफ्फेलस्क्रिप्ट™
dbb9475b7b refactor(core): Remove NodeExecutionOutput. Add execution hints directly to the context (#13111) 2025-02-10 16:51:01 +01:00
Michael Kret
4c2546dc78 feat: Do not assign all paired items (no-changelog) (#11716) 2025-02-06 13:46:28 +00:00
Shireen Missi
83ce3a9096 fix(Postgres Node): Allow using composite key in upsert queries (#12639)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2025-01-17 08:42:46 +00:00
Danny Martini
35cb10c5e7 refactor(Postgres Node): Backport connection pooling to postgres v1 (#12484) 2025-01-16 11:09:12 +01:00
Dana
9dd068632b fix(Postgres Node): Allow passing in arrays to JSON columns for insert (#12452) 2025-01-08 09:41:51 +00:00
Danny Martini
2ca37f5f7f fix(Postgres Node): Re-use connection pool across executions (#12346)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-12-27 09:15:37 +01:00
Dana
06b86af735 fix(Postgres Node): Account for JSON expressions (#12012)
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
2024-12-20 18:35:23 +01:00
कारतोफ्फेलस्क्रिप्ट™
bafac73eb5 refactor: Impose import/order linting rule across nodes packages (no-changelog) (#12314) 2024-12-19 18:46:14 +01:00
Dana
0c15e30778 fix(Postgres Node): Allow users to wrap strings with $$ (#12034) 2024-12-16 17:02:48 +00:00
Ria Scholz
3c57f46aae fix(Postgres Node): Special datetime values cause errors (#11225)
Co-authored-by: Elias Meire <elias@meire.dev>
2024-10-22 12:02:39 +02:00
oleg
ef5b7cf9b7 feat(core): Implement Dynamic Parameters within regular nodes used as AI Tools (#10862) 2024-10-02 13:31:22 +02:00
Michael Kret
4a63cff5ec fix(Postgres Node): Falsy query parameters ignored (#10960) 2024-09-26 16:09:13 +01:00
Iván Ovejero
05e609d714 build: Upgrade nodelinter to 1.16.2 (no-changelog) (#10779) 2024-09-12 16:53:36 +02:00
Ricardo Espinoza
c4eb3746d7 refactor: Use NodeConnectionType consistently across the code base (no-changelog) (#10595) 2024-08-29 09:55:53 -04:00
कारतोफ्फेलस्क्रिप्ट™
be52176585 refactor(core): Allow custom types on getCredentials (no-changelog) (#10567) 2024-08-27 15:23:58 +02:00
Michael Kret
ce46bf516a fix(Google Sheets Node): Better error when column to match on is empty (#10442)
Co-authored-by: Shireen Missi <shireen@n8n.io>
2024-08-16 15:59:59 +01:00
Shireen Missi
519fc4d753 fix(Postgres Node): Expressions in query parameters for Postgres executeQuery operation (#10217) 2024-07-31 08:39:37 +01:00
Jon
4d37b9669f docs: Update add options text (no-changelog) (#10049) 2024-07-29 13:27:23 +01:00
Michael Kret
00ec253337 fix(Postgres Node): Option to treat query parameters enclosed in single quotas as text (#10214) 2024-07-29 14:48:11 +03:00
कारतोफ्फेलस्क्रिप्ट™
85aa560a5d refactor(core): Centralize SSH Tunnel management (#9906)
Co-authored-by: Michael Kret <michael.k@radency.com>
2024-07-04 12:29:44 +02:00
Iván Ovejero
44ea4c73eb refactor: Remove unused lint directives (no-changelog) (#9842) 2024-06-24 12:13:18 +02:00
Michael Kret
870412f093 feat(core): Node hints improvements (no-changelog) (#9387)
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-05-22 13:35:29 +03:00
aya
e896889394 feat(Postgres Node): Add option IS NOT NULL and hide value input fields (#9241) 2024-05-02 10:08:57 +01:00
Michael Kret
08e35027f1 fix(Postgres Node): Convert js arrays to postgres type, if column type is ARRAY (#9160) 2024-04-18 12:58:04 +03:00
Michael Kret
58518b684b feat(Postgres Node): Options keepAlive and keepAliveInitialDelayMillis (#9067) 2024-04-09 18:41:51 +03:00
कारतोफ्फेलस्क्रिप्ट™
457cac4cf9 fix(Postgres Node): Close connection pool only if it's not already closed or closing (#8690) 2024-02-21 11:27:21 +01:00
Tomi Turtiainen
9a1cc56806 fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) (#8363)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-17 17:08:50 +02:00
Elias Meire
bed04ec122 fix(Postgres Node): Stop marking autogenerated columns as required (#8230)
## Summary

Postgres columns can be
- [generated as
identity](https://www.postgresqltutorial.com/postgresql-tutorial/postgresql-identity-column/)
- [generated by a custom
expression](https://www.postgresql.org/docs/current/ddl-generated-columns.html)

In these 2 cases, the column is not required when inserting a new row.
This PR makes sure these types of column are not marked required in n8n.

### How to test

1. Create a Postgres table with all types of generated columns:
for version >= 10
  ```sql
  CREATE TABLE "public"."test_table" (
      "id" int8 NOT NULL DEFAULT nextval('test_table_id_seq'::regclass),
      "identity_id" bigint GENERATED ALWAYS AS IDENTITY,
      "id_plus" numeric GENERATED ALWAYS AS (id + 5) STORED,
      "title" varchar NOT NULL,
      "created_at" timestamp DEFAULT now(),
      PRIMARY KEY ("id")
  )
  ```
  Before 10 you have to use serial or bigserial types:
  ```sql
  CREATE TABLE distributors (
     did    serial not null primary key,
     name   varchar(40) NOT NULL CHECK (name <> '')
);
  ```
2. Add a postgres node to canvas and try to insert data without the
generated columns
3. Should successfully insert

More info in Linear/Github issue ⬇️ 

## Related tickets and issues
- fixes #7084
-
https://linear.app/n8n/issue/NODE-816/rmc-not-all-id-fields-should-be-required
-
https://linear.app/n8n/issue/NODE-681/postgres-cant-map-automatically-if-database-requires-a-field

## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2024-01-05 12:37:33 +01:00
Elias Meire
071e6d6b6e feat(editor): Add fullscreen view to code editor (#8084)
## Summary

<img width="1240" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a">
<img width="2649" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe">

1. Add code node and open it
3. Click the fullscreen button in the bottom right
4. A fullscreen dialog should appear and allow editing the code
5. Changes made in the fullscreen dialog should be applied to the
original code editor when closed

It should work the same way for HTML/SQL/JSON editors

⚠️ Modal layout was updated so that modals/dialogs are centered, try to
test some modals

## Related tickets and issues
https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node



## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
2024-01-04 17:23:24 +01:00
Michael Kret
435392cbfe fix(Postgres Node): Do not include id column in upsert fields selection if it's not unique (#7975)
## Summary
Do not include id column in upsert fields selection if it's not unique
Forum:
https://community.n8n.io/t/postgres-node-insert-or-update-unique-column-name/32520
2023-12-11 17:34:24 +02:00
Jon
97e39c39d9 docs: Replace references to set node (no-changelog) (#7973)
## Summary
This replaces the set node references with edit fields.

Ref: https://n8nio.slack.com/archives/C036PA5D42D/p1702040900165709
2023-12-11 10:10:03 +00:00
Iván Ovejero
62c096710f refactor: Run lintfix (no-changelog) (#7537)
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Michael Kret
e2c3c7aceb fix(core): Missing pairing info (#7326)
Github issue / Community forum post (link here to close automatically):
2023-10-10 18:36:20 +03:00
Michael Kret
763d4514fa fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression (#7300)
Github issue / Community forum post (link here to close automatically):
2023-09-29 13:27:31 +03:00
Michael Kret
3a474552b2 feat(Set Node): Overhaul (#6348)
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/pull/6348

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
2023-09-19 13:16:35 +03:00
कारतोफ्फेलस्क्रिप्ट™
92af1314fe fix(Postgres Node): Fix automatic column mapping (#7121)
NODE-757
2023-09-06 16:32:50 +02:00
कारतोफ्फेलस्क्रिप्ट™
6aa7b93473 refactor(core): Deprecate prepareOutputData (no-changelog) (#7091) 2023-09-05 12:59:02 +02:00
Michael Kret
58e55ba669 fix(Postgres Node): Tunnel doesn't always close (#7087) 2023-09-04 13:26:02 +03:00
Michael Kret
9dd5f0e579 fix(Postgres Node): Connection pool of the database object has been destroyed (#7074)
Github issue / Community forum post (link here to close automatically):
2023-09-01 22:19:10 +03:00
Michael Kret
176ccd62bc fix(Postgres Node): Empty return data fix for Postgres and MySQL (#7016) 2023-08-25 18:38:09 +03:00
Jon
0e075c9cb5 fix: Fix issue with key formatting introduced in 1.2.0 (#6896) 2023-08-09 16:23:35 +01:00
Jon
db21a8db75 fix: Fix issue with key based credentials not being read correctly (#6824) 2023-08-09 12:30:53 +01:00
Iván Ovejero
24ce141815 refactor: Clear unused ESLint directives from nodes-base (no-changelog) (#6812)
* refactor: Clear unused ESLint directives from nodes-base (no-changelog)

* removed unused disable directives

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-08-01 15:32:33 +02:00
Michael Kret
4cae091cfb fix(Postgres Node): Arrays in query replacement fix (#6718) 2023-07-25 15:34:45 +03:00