Commit Graph

8 Commits

Author SHA1 Message Date
कारतोफ्फेलस्क्रिप्ट™
979f9e6327 refactor: Overhaul nodes-testing setup - Part 3 (no-changelog) (#14967) 2025-04-29 17:42:21 +02:00
कारतोफ्फेलस्क्रिप्ट™
91069f057e refactor: Overhaul nodes-testing setup - Part 2 (no-changelog) (#14873) 2025-04-24 17:37:26 +02:00
कारतोफ्फेलस्क्रिप्ट™
73e8d76e13 refactor: Overhaul nodes-testing setup - Part 1 (no-changelog) (#14303) 2025-04-01 10:15:13 +02:00
कारतोफ्फेलस्क्रिप्ट™
bafac73eb5 refactor: Impose import/order linting rule across nodes packages (no-changelog) (#12314) 2024-12-19 18:46:14 +01:00
Iván Ovejero
62c096710f refactor: Run lintfix (no-changelog) (#7537)
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Iván Ovejero
6d6e2488c6 refactor(core): Generalize binary data manager interface (no-changelog) (#7164)
Depends on: #7092 | Story:
[PAY-768](https://linear.app/n8n/issue/PAY-768)

This PR: 
- Generalizes the `IBinaryDataManager` interface.
- Adjusts `Filesystem.ts` to satisfy the interface.
- Sets up an S3 client stub to be filled in in the next PR.
- Turns `BinaryDataManager` into an injectable service.
- Adjusts the config schema and adds new validators.

Note that the PR looks large but all the main changes are in
`packages/core/src/binaryData`.

Out of scope:
- `BinaryDataManager` (now `BinaryDataService`) and `Filesystem.ts` (now
`fs.client.ts`) were slightly refactored for maintainability, but fully
overhauling them is **not** the focus of this PR, which is meant to
clear the way for the S3 implementation. Future improvements for these
two should include setting up a backwards-compatible dir structure that
makes it easier to locate binary data files to delete, removing
duplication, simplifying cloning methods, using integers for binary data
size instead of `prettyBytes()`, writing tests for existing binary data
logic, etc.

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-09-22 17:22:12 +02:00
कारतोफ्फेलस्क्रिप्ट™
e57e85edf7 refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) (#6631) 2023-07-12 11:15:38 +02:00
Marcus
e01192e7af test(Read Binary File Node): Unit tests (no-changelog) (#5436)
 add Read Binary Data node unit test

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-02-09 15:31:10 +01:00