Commit Graph

27 Commits

Author SHA1 Message Date
Michael Kret
479644a499 refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ (#4523)
*  rule and fixes

*  clean up
2022-11-08 15:28:21 +01:00
Michael Kret
91d7e16c81 n8n-3867-progressively-apply-prettier-to-all (#3873)
* 🔨 formatting nodes with prettier
2022-08-17 17:50:24 +02:00
pemontto
07b6cffdba feat(Jira Node): Use Jira rendered fields with simplify option (#3323)
* 💄 Use Jira rendered fields with simplify

* 🐛 Merge the renderedField results with fields

*  improvements

*  Improvements

Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-07-04 11:43:37 +02:00
Omar Ajoue
d3fecb9f6d 🎨 Centralize error throwing for encryption keys and credentials (#3105)
* Centralized error throwing for encryption key

* Unifying the error message used by cli and core packages

* Improvements to error messages to make it more DRY

* Removed unnecessary throw

* Throwing error when credential does not exist to simplify node behavior (#3112)

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2022-04-15 08:00:47 +02:00
pemontto
016aeaaa79 feat(Jira Node): Add Simplify Output option to Issue > Get (#2408)
*  Add option to use Jira field display names

* 🚸 Make mapped fields more deterministic

* ♻️ Refactor Jira user loadOptions

* Moved and renamed the option as well as only returning the fields to

* Tweaked Friendly Fields to make it "Simplify Output" following similar patterns to other nodes

*  Improvements

Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2022-03-27 11:49:47 +02:00
Omar Ajoue
7ce7285f7a Load credentials from the database (#1741)
* Changes to types so that credentials can be always loaded from DB

This first commit changes all return types from the execute functions
and calls to get credentials to be async so we can use await.

This is a first step as previously credentials were loaded in memory and
always available. We will now be loading them from the DB which requires
turning the whole call chain async.

* Fix updated files

* Removed unnecessary credential loading to improve performance

* Fix typo

*  Fix issue

* Updated new nodes to load credentials async

*  Remove not needed comment

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-08-20 18:57:30 +02:00
Jan Oberhauser
353b911620 🐛 Remove console.log 2021-05-23 11:41:34 -05:00
Jan
ed6f2c5b8a Add Notion Node (#1811)
*  Notion Node

*  Improvements

* test

*  Improvements

*  Improvements

*  Add missing url field

* Remove linter errors

*  Add filters

*  Add and & or filters

*  Improvements

*  Improvements

*  Improvements

*  Improvements

*  Improvements

*  Improvements

*  Fixed style on some options

*  Improvements

*  Improvements

*  Improvements

*  Improvements

*  Improvements

*  improvements

*  Rename DatabasePage -> Search to Get All

*  Improvements

*  Minor improvements

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2021-05-20 16:31:23 -05:00
Iván Ovejero
1d27a9e87e Improve node error handling (#1309)
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

*  change return type of callback

*  add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

*  change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

*  add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

*  add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

*  add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

*  Replace current errors with custom errors (#1576)

*  Introduce NodeApiError in catch blocks

*  Introduce NodeOperationError in nodes

*  Add missing errors and remove incompatible

*  Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

*  Add XML parsing to NodeApiError

*  Simplify error handling in Rekognition node

*  Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

*  Find property in parsed XML

*  Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

*  Add custom errors to latest contributions

* 👕 Fix linting issues

*  Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

*  Apply feedback to A nodes

*  Apply feedback to missed A node

*  Apply feedback to B-D nodes

*  Apply feedback to E-F nodes

*  Apply feedback to G nodes

*  Apply feedback to H-L nodes

*  Apply feedback to M nodes

*  Apply feedback to P nodes

*  Apply feedback to R nodes

*  Apply feedback to S nodes

*  Apply feedback to T nodes

*  Apply feedback to V-Z nodes

*  Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

*  Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Ricardo Espinoza
46fe96b72c Extended Jira Node (#1306)
*  Add Issue Attachment resource

*  Add custom fields to issue:create and issue:update

*  Filter custom fields by the project selected

*  Change the logo to SVG

*  Small improvement

*  Minor improvements to Jira Node

*  Add download field to issueAttachment get and getAll

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-01-29 20:08:27 +01:00
Ricardo Espinoza
ad6155068e Jira retrieve all projects (#1140)
Fixes #1138
2020-11-10 07:43:39 +01:00
Jan Oberhauser
40c2acd77b 👕 Fix lint issue 2020-10-22 15:46:03 +02:00
Jan Oberhauser
fe802c8f76 👕 Fix built issue by fixing lint issues 2020-10-01 15:18:47 +02:00
Ricardo Espinoza
d35548c424 Jira-Trigger (#778)
*  Jira-Trigger

*  Improvements
2020-07-25 10:22:02 +02:00
Jan Oberhauser
79a09c98a7 Minor improvements to Jira-Node 2020-05-05 22:56:24 +02:00
zou wendi
e4cc3a4bc9 features: support jira self-hosted server 2020-05-05 12:07:19 +08:00
Jan Oberhauser
f8869f85e8 Small improvements to Jira-Node 2020-04-24 09:50:56 +02:00
ricardo
e19db703ce Added update status to issues 2020-04-24 00:59:19 -05:00
Jan Oberhauser
201dd95c90 Small improvements on Jira-Node 2020-02-06 19:03:29 -08:00
Ricardo Espinoza
960d439cbc fixes 2020-02-02 10:01:56 -05:00
Ricardo Espinoza
7d5bbadc9b small fix 2020-02-01 18:20:23 -05:00
Ricardo Espinoza
94b13ddea2 Support for Jira server 2020-02-01 18:15:56 -05:00
Ricardo Espinoza
c06934d973 Jira Software Server node 2020-01-31 10:21:14 -05:00
Ricardo Espinoza
9def6cd6ae Issue resource done 2019-11-29 17:30:00 -05:00
Ricardo Espinoza
8e5ad3f4b1 Renamed and added interfaces 2019-11-28 01:10:41 -05:00
Ricardo Espinoza
bb2ba588f5 issue:create done 2019-11-27 17:42:28 -05:00
Ricardo Espinoza
1c9a78e624 🎉 node-setup 2019-11-26 15:38:38 -05:00